-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zipkin-to-stackdriver yaml to addons #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
this PR passes on my local cluster and on the IBM cluster and should have no impact on anything other than adding an option for running an add-on. i'm going to merge unless there is any objection. |
@douglas-reid: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ZackButcher, andraxylia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
thanks! this was the last (non-Mixer) piece in the stackdriver mvp. |
Former-commit-id: 3e3ed64
This PR adds deployment/service yaml to
install/kubernetes/addons
.Tested with an openzipkin cli that generates zipkin traces and sends them to my (port-forwarded) instance of this deployment.
Release note: