Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipkin-to-stackdriver yaml to addons #668

Merged
merged 3 commits into from
Sep 6, 2017
Merged

Add zipkin-to-stackdriver yaml to addons #668

merged 3 commits into from
Sep 6, 2017

Conversation

douglas-reid
Copy link
Contributor

@douglas-reid douglas-reid commented Sep 5, 2017

This PR adds deployment/service yaml to install/kubernetes/addons.

Tested with an openzipkin cli that generates zipkin traces and sends them to my (port-forwarded) instance of this deployment.

Release note:

NONE

Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@douglas-reid
Copy link
Contributor Author

douglas-reid commented Sep 5, 2017

this PR passes on my local cluster and on the IBM cluster and should have no impact on anything other than adding an option for running an add-on.

i'm going to merge unless there is any objection.

@istio-testing
Copy link
Collaborator

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh 3eec6bf link /test e2e-suite-rbac-auth
prow/e2e-suite-rbac-no_auth.sh 3eec6bf link /test e2e-suite-rbac-no_auth
prow/e2e-suite-no_rbac-no_auth.sh 3eec6bf link /test e2e-suite-no_rbac-no_auth
prow/e2e-suite-no_rbac-auth.sh 3eec6bf link /test e2e-suite-no_rbac-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia
Copy link
Contributor

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZackButcher, andraxylia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@douglas-reid douglas-reid merged commit 3e3ed64 into istio:master Sep 6, 2017
@douglas-reid
Copy link
Contributor Author

thanks! this was the last (non-Mixer) piece in the stackdriver mvp.

rshriram pushed a commit that referenced this pull request Oct 30, 2017
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants