Add values for config map settings, including access log. #6797

costinm · 2018-07-02T23:07:25Z

Allow helm to configure few more istio config settings at install time.

More docs.

rshriram · 2018-07-03T00:21:48Z

install/kubernetes/helm/istio/templates/configmap.yaml

    #
    # To disable the mixer completely (including metrics), comment out
    # the following lines
+    # Deprecated: mixer is using EDS
    mixerCheckServer: istio-policy.{{ .Release.Namespace }}.svc.cluster.local:15004


I think people wanted to configure this as well.. especially the svc.cluster.local as some ebay folks said that they have non default domains. so having this will break their system. In fact, Pilot also has an option to specify the cluster domain (I think). That needs to percolate

You're right, still needed for that. Will remove the deprecated.

Maybe we should have an option to override the entire name ( so it can be pointed to DNS entry, for multicluster ) ?

rshriram · 2018-07-03T00:22:13Z

install/kubernetes/helm/istio/templates/configmap.yaml

@@ -30,6 +33,7 @@ data:
    # from istio Pilot. Lower refresh delay results in higher CPU
    # utilization and potential performance loss in exchange for faster
    # convergence. Tweak this value according to your setup.
+    # Deprecated: using push.
    rdsRefreshDelay: {{ .Values.global.refreshInterval }}


please remove.. We are not supporting any form of v1 in 1.0. So, having this here merely adds to confusion.

rshriram · 2018-07-03T00:22:20Z

install/kubernetes/helm/istio/templates/configmap.yaml

@@ -44,6 +48,7 @@ data:
      # NOTE: If you change any values in this section, make sure to make
      # the same changes in start up args in istio-ingress pods.
      # See rdsRefreshDelay for explanation about this setting.
+      # Deprecated: using push.
      discoveryRefreshDelay: {{ .Values.global.refreshInterval }}


same as above

rshriram

..

sdake

looks pretty good - should be mergeable once @rshriram 's comments are addressed. I had a cosmetic suggestion - feel tree to use or not.

Cheers
-steve

sdake · 2018-07-03T05:53:29Z

install/kubernetes/helm/istio/templates/configmap.yaml

    # Set accessLogFile to empty string to disable access log.
-    accessLogFile: "/dev/stdout"
+    accessLogFile: "{{ .Values.global.proxy.accessLogFile }}"


sdake · 2018-07-03T05:54:36Z

install/kubernetes/helm/istio/values.yaml

-  # Should track latest released version in the branch.
-  tag: 0.8.latest
+  tag: nightly-master
+  #tag: 1.0.latest


is this leftover?

No, in the branch it'll have a different value. We want each branch to default to latest nightly build ( or daily - if they start getting stable tags ). This way someone can use the templates and test the release - without setting a tag override or building.

sdake · 2018-07-03T05:54:42Z

install/kubernetes/helm/istio/values.yaml

-  # docker.io/istionightly
-  hub: docker.io/istio
+  hub: docker.io/istionightly
+  #hub: docker.io/istio


is this leftover?

Same.. I can remove the commented out - and have each branch have it's own version.

sdake · 2018-07-03T05:55:49Z

install/kubernetes/helm/istio/values.yaml

-    policy: enabled
+
+    # This controls the 'policy' in the sidecar injector.
+    autoinject: enabled


should this be autoInject for consistency?

good point. Policy was very confusing - we also have the mixer policy.

codecov · 2018-07-03T20:16:02Z

Codecov Report

Merging #6797 into master will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6797   +/-   ##
======================================
+ Coverage      71%     71%   +1%     
======================================
  Files         367     368    +1     
  Lines       31956   31926   -30     
======================================
- Hits        22575   22574    -1     
+ Misses       8457    8419   -38     
- Partials      924     933    +9

Impacted Files	Coverage Δ
mixer/adapter/signalfx/cumulative.go	`67% <0%> (-4%)`	⬇️
galley/pkg/mcp/client/client.go	`71% <0%> (-4%)`	⬇️
mixer/adapter/servicecontrol/checkprocessor.go	`80% <0%> (-1%)`	⬇️
mixer/adapter/kubernetesenv/cache.go	`92% <0%> (-1%)`	⬇️
mixer/adapter/opa/opa.go	`79% <0%> (-1%)`	⬇️
pilot/pkg/model/authentication.go	`73% <0%> (ø)`	⬇️
mixer/pkg/protobuf/yaml/dynamic/builder.go	`99% <0%> (ø)`	⬇️
pilot/pkg/model/conversion.go	`89% <0%> (ø)`	⬇️
mixer/adapter/list/ipList.go	`100% <0%> (ø)`	⬆️
mixer/adapter/servicecontrol/client.go	`0% <0%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d0e30...28bfe53. Read the comment docs.

costinm · 2018-07-03T20:21:30Z

Sorry, messed up the branches - need to submit the long-running test changes first...

costinm · 2018-07-03T20:33:44Z

Please take another look. I messed up the branches - had 2 PRs depending on each other ( the test templates ). I fixed the comments and added the matching changes for remote.

I'll do a separate PR to match remote values with the main cluster values.

istio-testing · 2018-07-03T20:34:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: costinm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~install/OWNERS~~ [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* fix bug so that destination.service.** attributes are collected (#6801) * remove unnecessary generated attributes finding. (#6785) * modify docker template files for proxyv2 (#6790) * Long-running testing improvements (#6800) * Add values for config map settings, including access log. More docs. * Updates and improvements for the stress-testing configs. * Add values for config map settings, including access log. (#6797) * Add values for config map settings, including access log. More docs. * Updates and improvements for the stress-testing configs. * Address review comments * Merged wrong files * Add the setup helm file - this change now depend on the previous PR. * Sync with remote, remove accidentally added files. * Another accidental file * SNI routing from sidecar to gateway with virtual services (#6402) * quick sni matching 1st pass with no refactoring of existing code * use shriram's api sha * quick pass at using tls block * add some validation * copyright * fix lint + remove deadcode * rename protocol tcp_tls -> tls * update back to istio/api master * remove accidentally added test file * add tls block to gateway logic * add todos * basic sni wildcard implementation * add tcp, fix problems with rbac, matching * better tcp + tls validation * address code review comments * remove out of date comment * update comments * fix compile error * use tcp proxy in tcp routing * add tcp routing e2e test * add forgotten vs config file + update description of test * Comments, bug fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * cleanup gateway tcp test Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * moving networking test yamls Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * tcp/tls tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * yaml fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix file switcheroo * port matches Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix authN plugin overwriting TLS context Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * more tests - route via egress gateway Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * yaml fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * initialize prom variables Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * split tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * final test fix hopefully Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * revert gateway tweaks Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Introducing mcpc, a command-line mcp client tool. (#6715) * Set default requests cpu resource to all deployments (#6229) * Set default requests cpu resource to all deployments * Description added * Requested CPU decreased to meet test env node capacity * Setting requested cpu to 10m as most k8s platforms are defaulting to 0m * Merge master remains * Apply the global resources to the new gateways * Updated goldens to cpu 10m * Clean up and rename the global default resources * Redundant Redis servers were removed + defer in a loop is not recommended. (#6768) * Fix upgrade. (#6792) * Fix upgrade. * Format * Move back the fail close - not clear if we have time to get mixer client in this build, we can remove in next * Add configuration to allow transformation of durations to integers. (#5416) The fluentd handler currently transforms durations to their string representation for log messages. This commit adds a configuration to override this default behaviour and tranform durations to integers of unit millisecond. * Add workload and service dashboard (#6789) * Add workload and service dashboard * fix typo * Skip service dash e2e test for now * Add rushed, missed workload dash * Touch up * Commenting out test until can replicate locally and fix * simplify fmt script (#6798) * simplify fmt script - goimports is a superset of gofmt - shouldn't need to remove spaces - now utilizing -l flag to tell us if there is a diff * always update gofmt to latest * spacing that is now considered incorrect * support hash based routing for soft session affinity (#6742) * support sticky sessions * fmt :( * update servicediscovery fakes * bump istio/api * use updated api for ring hash * support session affinity for sidecar * update destination rule yaml to reflect new api * ttl is a string * unset sdsUdsPath in configmap (#6799) * fix bug so that destination.service.** attributes are collected (#6801) * remove unnecessary generated attributes finding. (#6785) * modify docker template files for proxyv2 (#6790) * Long-running testing improvements (#6800) * Add values for config map settings, including access log. More docs. * Updates and improvements for the stress-testing configs. * Add values for config map settings, including access log. (#6797) * Add values for config map settings, including access log. More docs. * Updates and improvements for the stress-testing configs. * Address review comments * Merged wrong files * Add the setup helm file - this change now depend on the previous PR. * Sync with remote, remove accidentally added files. * Another accidental file * SNI routing from sidecar to gateway with virtual services (#6402) * quick sni matching 1st pass with no refactoring of existing code * use shriram's api sha * quick pass at using tls block * add some validation * copyright * fix lint + remove deadcode * rename protocol tcp_tls -> tls * update back to istio/api master * remove accidentally added test file * add tls block to gateway logic * add todos * basic sni wildcard implementation * add tcp, fix problems with rbac, matching * better tcp + tls validation * address code review comments * remove out of date comment * update comments * fix compile error * use tcp proxy in tcp routing * add tcp routing e2e test * add forgotten vs config file + update description of test * Comments, bug fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * cleanup gateway tcp test Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * moving networking test yamls Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * tcp/tls tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * yaml fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix file switcheroo * port matches Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix authN plugin overwriting TLS context Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * more tests - route via egress gateway Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * yaml fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * initialize prom variables Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * split tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * final test fix hopefully Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * revert gateway tweaks Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * Add myself back to OWNERS, sort the list alphabetically. (#6830) * Upload cloudfoundry test result to GCS (#6829) * Fix typos in command-line output.

Add values for config map settings, including access log.

06c0845

More docs.

googlebot added the cla: yes label Jul 2, 2018

istio-testing requested review from GregHanson and ijsnellf July 2, 2018 23:07

istio-testing added the approved label Jul 2, 2018

costinm requested review from sdake, douglas-reid and hklai and removed request for ijsnellf and GregHanson July 2, 2018 23:07

rshriram reviewed Jul 3, 2018

View reviewed changes

Updates and improvements for the stress-testing configs.

2507b1d

sdake reviewed Jul 3, 2018

View reviewed changes

costinm added 2 commits July 3, 2018 13:10

Merge branch 'master' of github.com:istio/istio into costin-install

de53177

Address review comments

e3e277f

costinm added 2 commits July 3, 2018 13:20

Merged wrong files

8259d8c

Add the setup helm file - this change now depend on the previous PR.

6c44c14

costinm added 2 commits July 3, 2018 13:23

Merge branch 'master' of github.com:istio/istio into costin-install

11571ce

Sync with remote, remove accidentally added files.

d6b96e5

Another accidental file

28bfe53

rshriram approved these changes Jul 3, 2018

View reviewed changes

rshriram merged commit 65a76fb into istio:master Jul 3, 2018

nmittler mentioned this pull request Jul 20, 2018

Cherry picking bug fixes from master into release-1.0 #6834

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add values for config map settings, including access log. #6797

Add values for config map settings, including access log. #6797

costinm commented Jul 2, 2018

rshriram Jul 3, 2018

costinm Jul 3, 2018

rshriram Jul 3, 2018

costinm Jul 3, 2018

rshriram Jul 3, 2018

rshriram left a comment

sdake left a comment

sdake Jul 3, 2018

sdake Jul 3, 2018

costinm Jul 3, 2018

sdake Jul 3, 2018

costinm Jul 3, 2018

sdake Jul 3, 2018

costinm Jul 3, 2018

codecov bot commented Jul 3, 2018 •

edited

costinm commented Jul 3, 2018

costinm commented Jul 3, 2018

istio-testing commented Jul 3, 2018

Add values for config map settings, including access log. #6797

Add values for config map settings, including access log. #6797

Conversation

costinm commented Jul 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rshriram left a comment

Choose a reason for hiding this comment

sdake left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 3, 2018 • edited

Codecov Report

costinm commented Jul 3, 2018

costinm commented Jul 3, 2018

istio-testing commented Jul 3, 2018

codecov bot commented Jul 3, 2018 •

edited