Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge latest master into collab-gcp-identity #6889

Merged
merged 19 commits into from Jul 7, 2018
Merged

merge latest master into collab-gcp-identity #6889

merged 19 commits into from Jul 7, 2018

Conversation

quanjielin
Copy link
Contributor

No description provided.

ozevren and others added 19 commits July 2, 2018 12:33
@ozevren @istio-testing
Introducing mcpc, a command-line mcp client tool. (istio#6715)
df49d93
@ymesika @istio-testing
Set default requests cpu resource to all deployments (istio#6229)
e5a09e9 
* Set default requests cpu resource to all deployments

* Description added

* Requested CPU decreased to meet test env node capacity

* Setting requested cpu to 10m as most k8s platforms are defaulting to 0m

* Merge master remains

* Apply the global resources to the new gateways

* Updated goldens to cpu 10m

* Clean up and rename the global default resources
@ymesika @istio-testing
Redundant Redis servers were removed + defer in a loop is not recomme…
2b4e499 
…nded. (istio#6768)
@costinm
Fix upgrade. (istio#6792)
855fdd7 
* Fix upgrade.

* Format

* Move back the fail close - not clear if we have time to get mixer client in this build, we can remove in next
@jeffmendoza @istio-testing
Add configuration to allow transformation of durations to integers. (i…
664bb4a 
…stio#5416)

The fluentd handler currently transforms durations to their string
representation for log messages. This commit adds a configuration to
override this default behaviour and tranform durations to integers of
unit millisecond.
@douglas-reid @hklai
Add workload and service dashboard (istio#6789)
ff97924 
* Add workload and service dashboard

* fix typo

* Skip service dash e2e test for now

* Add rushed, missed workload dash

* Touch up

* Commenting out test until can replicate locally and fix
@zachgersh @rshriram
simplify fmt script (istio#6798)
8404985 
* simplify fmt script

- goimports is a superset of gofmt
- shouldn't need to remove spaces
- now utilizing -l flag to tell us if there is a diff

* always update gofmt to latest

* spacing that is now considered incorrect
@utako @rshriram
support hash based routing for soft session affinity (istio#6742)
276e1b2 
* support sticky sessions

* fmt :(

* update servicediscovery fakes

* bump istio/api

* use updated api for ring hash

* support session affinity for sidecar

* update destination rule yaml to reflect new api

* ttl is a string
@quanjielin @istio-testing
unset sdsUdsPath in configmap (istio#6799)
cacc188
@quanjielin @istio-testing
fix bug so that destination.service.** attributes are collected (isti…
4bf22f4 
…o#6801)
@bianpengyuan @istio-testing
remove unnecessary generated attributes finding. (istio#6785)
dc5264b
@GregHanson @rshriram
modify docker template files for proxyv2 (istio#6790)
a82c55a
@costinm
Long-running testing improvements (istio#6800)
62d0e30 
* Add values for config map settings, including access log.
More docs.

* Updates and improvements for the stress-testing configs.
@costinm @rshriram
Add values for config map settings, including access log. (istio#6797)
65a76fb 
* Add values for config map settings, including access log.
More docs.

* Updates and improvements for the stress-testing configs.

* Address review comments

* Merged wrong files

* Add the setup helm file - this change now depend on the previous PR.

* Sync with remote, remove accidentally added files.

* Another accidental file
@ijsnellf @rshriram
SNI routing from sidecar to gateway with virtual services (istio#6402)
560c9f9 
* quick sni matching 1st pass with no refactoring of existing code

* use shriram's api sha

* quick pass at using tls block

* add some validation

* copyright

* fix lint + remove deadcode

* rename protocol tcp_tls -> tls

* update back to istio/api master

* remove accidentally added test file

* add tls block to gateway logic

* add todos

* basic sni wildcard implementation

* add tcp, fix problems with rbac, matching

* better tcp + tls validation

* address code review comments

* remove out of date comment

* update comments

* fix compile error

* use tcp proxy in tcp routing

* add tcp routing e2e test

* add forgotten vs config file + update description of test

* Comments, bug fixes

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* cleanup gateway tcp test

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* moving networking test yamls

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tcp/tls tests

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* yaml fixes

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* fix file switcheroo

* port matches

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* fix authN plugin overwriting TLS context

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* more tests - route via egress gateway

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* yaml fixes

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* initialize prom variables

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* split tests

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* final test fix hopefully

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* revert gateway tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@ZackButcher @rshriram
Add myself back to OWNERS, sort the list alphabetically. (istio#6830)
8def5fe
@chxchx @rshriram
Upload cloudfoundry test result to GCS (istio#6829)
572ef95
Fix typos in command-line output.
865e90e
@quanjielin
Merge remote-tracking branch 'upstream/master' into quanlinim1
92aabfd
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jul 6, 2018
@codecov
Copy link

codecov bot commented Jul 6, 2018 •
edited

Codecov Report

Merging #6889 into collab-gcp-identity will decrease coverage by 1%.
The diff coverage is 23%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           collab-gcp-identity   #6889    +/-   ##
====================================================
- Coverage                   71%     71%   -<1%     
====================================================
  Files                      370     369     -1     
  Lines                    31780   31803    +23     
====================================================
- Hits                     22461   22340   -121     
- Misses                    8401    8548   +147     
+ Partials                   918     915     -3
Impacted Files Coverage Δ
istioctl/cmd/istioctl/main.go 43% <ø> (ø) ⬆️
mixer/pkg/config/crd/init.go 0% <ø> (ø) ⬆️
galley/pkg/kube/interfaces.go 73% <ø> (ø) ⬆️
mixer/adapter/circonus/circonus.go 72% <ø> (-1%) ⬇️
pilot/pkg/config/kube/crd/client.go 1% <ø> (ø) ⬆️
security/pkg/caclient/protocol/protocol.go 42% <ø> (ø) ⬆️
broker/pkg/platform/kube/crd/client.go 75% <ø> (ø) ⬆️
...ilot/pkg/networking/core/v1alpha3/networkfilter.go 0% <0%> (ø) ⬆️
pilot/pkg/model/service.go 77% <0%> (ø) ⬆️
pilot/pkg/networking/core/v1alpha3/httproute.go 25% <0%> (+1%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c965f1...92aabfd. Read the comment docs.

@quanjielin quanjielin removed the request for review from andraxylia July 6, 2018 18:35
@hklai
Copy link
Contributor

hklai commented Jul 6, 2018

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, quanjielin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jul 7, 2018
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@istio-testing istio-testing merged commit 118a828 into istio:collab-gcp-identity Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hklai hklai Awaiting requested review from hklai

Assignees

@hklai hklai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet