Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Auto PR to update dependencies of istio #680

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Auto PR to update dependencies of istio #680

wants to merge 1 commit into from

Conversation

istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented Sep 6, 2017 •
edited
Loading

This PR will be merged automatically once checks are successful.

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator Author

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-no_auth.sh f112ac0 link /test e2e-suite-rbac-no_auth
prow/e2e-suite-rbac-auth.sh f112ac0 link /test e2e-suite-rbac-auth
prow/e2e-suite-no_rbac-no_auth.sh f112ac0 link /test e2e-suite-no_rbac-no_auth
prow/e2e-suite-no_rbac-auth.sh f112ac0 link /test e2e-suite-no_rbac-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link

@istio-testing PR needs rebase

@istio-merge-robot istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Sep 7, 2017
@istio-testing istio-testing deleted the autoUpdateDeps_047feae46a67e08fa920ba5946487bf4 branch September 7, 2017 20:47
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
@sebastienvas
Add the git tag to the docker image if it exists (istio#680)
4374c06 
Former-commit-id: 160a60f4022fbe35f4c53f3e6a70bf944f05108b
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@sebastienvas
Add the git tag to the docker image if it exists (#680)
bd5baf7 
Former-commit-id: 45918c70b5beed5c2b68dd828b76279d21918e88
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@kyessenov
Add more logging to the apiserver and istioctl (#680)
1cd0e57 
* Add more logging to the apiserver

Signed-off-by: Liam White <liamwhite@uk.ibm.com>

* More istioctl logging

Signed-off-by: Liam White <liamwhite@uk.ibm.com>
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@qiwzhang
Integrate with v2 mixer client config. (istio#680)
76ed00a
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@richardwxn @istio-testing
add tolerations to schema (istio#680)
f623b65
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@GregHanson @rshriram
re-add deprecated fields, but hide from docs. also resurrect outbound…
7ce9562 
… traffic policy config (istio#680)
luksa pushed a commit to luksa/istio that referenced this pull request Apr 11, 2024
@yannuil @openshift-merge-robot
Add IOR
78b8d40 
commit 466ae697aa72eac4172ab2f88d4d66c0d90d053d
Author: Yang Liu <yannliu@redhat.com>
Date:   Thu Mar 23 04:22:40 2023 +0800

    OSSM-1689 Simplify IOR (istio#747)

    * Rework IOR initialization

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove `initialSync`

    `initialSync` is not needed.

    - During boostrap, `SetNamesapces`is always called with no namespaces.
    - When removing or adding a namespace, the underlaying informer will
      trigger an `ADD` event for all resources the informer watches

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * DIsable TestPref

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Rename

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Call `findService` once for each gateway

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Use original host to generate Route name

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Skip duplicate update test

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Improve concurrency test

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Introduce update Route on Gateway update

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix data race

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Format and lint

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Respect log level

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Refactor IOR

    - `gatawayMap` is removed. `Routes` are retrived via API.
    -  `reconcileGateway` is used to achieve the desired state.
    - `processEvent` will only process the latest and try to abort early.

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove unused functions

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Use `Lister` for finding target service

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Start IOR before kube client

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove unused properties

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Rework test initialization

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Log correct debug information

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove unnecessary parameters

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove ResourceVersion usage

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Avoid deletion of a route when failing to update

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Update FakeRouter to record API call counts

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Rework initialization

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Keep startup process order consistent

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix creating matching service

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Test IOR to be idempotent

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove unused parameters

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Rename symbol

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Remove used struct

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Improve styling and wording

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Add support list across namespaces in faker

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Lint and format

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Introduce Openshift Route informer

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Lint

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Run make gen

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix data race

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix test data race

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Lint

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Rename variables

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix update route

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Linit

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Increase wait for the delete

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Maximize time to wait for the route deletion

    * Fix route update

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix route update

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Test with a 30 second wait

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Fix  flaky test

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Add disabling IOR and clean up

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Defer clean up

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * Clear only ior routes

    Signed-off-by: Yann Liu <yannliu@redhat.com>

    * rename newRoute to newRouteController

    * rename route.go to controller.go

    ---------

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
    Signed-off-by: Yann Liu <yannliu@redhat.com>

commit afe4692e69c68f7dc504550dd4770e4057431508
Author: Jonh Wendell <jonh.wendell@redhat.com>
Date:   Wed Nov 16 08:10:44 2022 -0500

    OSSM-2256: Add IOR (istio#680)

    * [ior] OSSM-2256: Add IOR

    * [ior] MAISTRA-1400 Add IOR to Pilot

    * [MAISTRA-1089][MAISTRA-1400][MAISTRA-1744][MAISTRA-1811]: Add IOR to Pilot (istio#135) (istio#240)

    * MAISTRA-1400: Add IOR to Pilot (istio#135)

    * MAISTRA-1400: Add IOR to Pilot

    * [MAISTRA-1744] Add route annotation propagation (istio#158)

    * MAISTRA-1811 Store resourceVersion of reconciled Gateway resource (istio#190)

    * MAISTRA-1089 Add support for IOR routes in all namespaces (istio#193)

    * MAISTRA-2131: ior: honor Gateway's httpsRedirect (istio#276)

    If Gateway's httpsRedirect is set to true, create the OpenShift Route
    with Insecure Policy set to `Redirect`.

    Manual cherrypick from maistra/istio#269.

    * MAISTRA-2149: Make IOR robust in multiple replicas (istio#282)

    In scenarios where multiple replicas of istiod are running,
    only one IOR should be in charge of keeping routes in sync
    with Istio Gateways. We achieve this by making sure IOR only
    runs in the leader replica.

    Also, because leader election is not 100% acurate, meaning
    that for a small window of time there might be two instances
    being the leader - which could lead to duplicated routes
    being created if a new gateway is created in that time frame -
    we also change the way the Route name is created: Instead of
    having a generateName field, we now explicitly pass a name to
    the Route object to be created. Being deterministic, it allows
    the Route creation to fail when there's already a Route object
    with the same name (created by the other leader in that time frame).

    Use an exclusive leader ID for IOR

    * Manual cherrypick of maistra/istio#275

    * MAISTRA-1813: Add unit tests for IOR (istio#286)

    * MAISTRA-2051 fixes for maistra install

    * MAISTRA-2164: Refactor IOR internals (istio#295)

    Instead of doing lots of API calls on every event - this
    does not scale well with lots of namespaces - keep the state
    in memory, by doing an initial synchronization on start up and
    updating it when receiving events.

    The initial synchronization is more complex, as we have to deal with
    asynchronous events (e.g., we have to wait for the Gateway store to
    be warmed up). Once it's initialized, handling events as they arrive
    becomes trivial.

    Tests that make sure we do not make more calls to the API server than
    the necessary were added, to avoid regressions.

    * MAISTRA-2205: Add an option to opt-out for automatic route creation

    If the Istio Gateway contains the annotation `maistra.io/manageRoute: false`
    then IOR ignores it and doesn't attempt to create or manage route(s) for
    this Gateway.

    Also, ignore Gateways with the annotation `istio: egressgateway` as
    these are not meant to have routes.

    * Add integration test for IOR

    Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

    * OSSM-1442: IOR: Ignore UPDATE events if resourceVersions are the same (istio#516)

    * OSSM-1442: IOR: Ignore UPDATE events if resourceVersions are the same

    For some obscure reason, it looks like we may receive UPDATE events with
    the new object being equal to the old one. As IOR always delete and
    recreate routes when receiving an UPDATE event, this might lead to some
    service downtime, given for a few moments the route will not exist.

    We guard against this behavior by comparing the `resourceVersion` field
    of the new object and the one stored in the Route object.

    * Add test

    Co-authored-by: Brian Avery <bavery@redhat.com>
    Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>

    Fix debug log formatting

    OSSM-1800: Copy gateway labels to routes

    Simplify the comparison of resource versions

    We store the gateway resource version (the whole metadata actually) in the `syncRoute` object.
    There's no need to loop over the routes to perform the comparison.

    This also fix the corner case where the gateway has one host and for
    some reason OCP rejects the creation of the route (e.g., when hostname is already
    taken). In this case the `syncRoute` object exists with zero routes in
    it. Thus the loop is a no-op and the function wrongly returns with an
    error of `eventDuplicatedMessage`. By comparing directly using the
    `syncRoute.metadata` we fix this.

    OSSM-1105: Support namespace portion in gateway hostnames

    They are not used by routes, so we essentially ignore the namespace part
    - anything on the left side of a "namespace/hostname" string.

    OSSM-1650 Make sure initialSync and event loop behave the same (istio#551)

    * OSSM-1301 Wait for Route resource type to become available on ior startup (istio#631)

    * OSSM-2109 Fix flaky IOR unit test (istio#648)

    The sleep in ensureNamespaceExists was hardcoded to 100ms, regardless of r.handleEventTimeout. This timeout during unit tests is only 1ms, so the 100ms sleep caused the for loop to only run once.

    Here we change the duration of the sleep to be 1/100 of r.handleEventTimeout. This change preserves the production sleep time of 100ms, but reduces the sleep time in unit tests to 10μs. This makes ensureNamespaceExists() run the for loop multiple times before giving up, fixing the test's flakiness.

    Co-authored-by: Marko Lukša <marko.luksa@gmail.com>

    * OSSM-2006 Fix multiNamespaceInformer.HasSynced()

    Co-authored-by: Jacek Ewertowski <jewertow@redhat.com>
    Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
    Co-authored-by: maistra-bot <57098434+maistra-bot@users.noreply.github.com>
    Signed-off-by: Yann Liu <yannliu@redhat.com>

Signed-off-by: Yann Liu <yannliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependency-update needs-rebase Indicates a PR needs to be rebased before being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@istio-testing @istio-merge-robot @googlebot