Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GROUPS.md #697

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Update GROUPS.md #697

merged 1 commit into from
Sep 8, 2017

Conversation

Brian-Xincheng-Zhang
Copy link
Contributor

Release note:

<PLEASE PUT RELEASE-NOTE HERE, PUT NONE if NO RELEASE-NOTE>

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: rshriram

Assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 7, 2017
@rshriram
Copy link
Member

rshriram commented Sep 7, 2017

Close until Andra's pr passes

@rshriram rshriram closed this Sep 7, 2017
@Brian-Xincheng-Zhang
Copy link
Contributor Author

Brian-Xincheng-Zhang commented Sep 8, 2017 via email

@rshriram rshriram reopened this Sep 8, 2017
@rshriram
Copy link
Member

rshriram commented Sep 8, 2017

non functional change to docs. merging.

@rshriram rshriram merged commit 097037e into master Sep 8, 2017
@rshriram rshriram deleted the Brian-Xincheng-Zhang-patch-1 branch September 8, 2017 01:35
@istio-testing
Copy link
Collaborator

@Brian-Xincheng-Zhang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-no_auth.sh 61f97e1 link /test e2e-suite-rbac-no_auth
prow/e2e-suite-rbac-auth.sh 61f97e1 link /test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Brian-Xincheng-Zhang
Copy link
Contributor Author

/retest

rshriram pushed a commit that referenced this pull request Oct 30, 2017
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
…lPlaneSecurity (istio#697)

* add a feature validation

* remove cmm.
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* add trust domain to meshconfig

* fix build

* add comment
incfly pushed a commit to incfly/istio that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants