Update README.md #729
Merged
Update README.md #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
gnirodi
approved these changes
Sep 11, 2017
|
/test all |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
…stio#729) * Add KUBECONFIG environment variable handling to kubernetes adapter. This PR primarily adds handling to kubernetes adapter to take the value for kubeconfigPath from mixer config as well as from environmental config (via the KUBECONFIG env var). NOTE: this configuration was previously available with via KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT env vars. This PR consolidates that into the Istio standard KUBECONFIG env var to harmonize deployment across componenets. Tested with out-of-the-box config via: ```bash $ KUBECONFIG=~/.kube/config bazel-bin/cmd/server/mixs server --configStoreURL=fs://$(pwd)/testdata/configroot --logtostderr -v=5 ``` and several client calls, as follows: ```bash $ bazel-bin/cmd/client/mixc report -v=45 -a target.service=foo.default.svc.cluster.local --string_attributes source.uid=kubernetes://productpage-v1-2087264475-bl9f2.default -m localhost:9091 --trace Report RPC returned OK Attribute Type Value source.labels map[string]string map[version:v1 app:productpage pod-template-hash:2087264475] source.name string productpage-v1-2087264475-bl9f2 source.namespace string default source.service string productpage.default.svc.cluster.local source.serviceAccount string default ``` * add override test bit Former-commit-id: 3c26a3b7c54cdb30b052f017bdd5306f6da6f0ad
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
Automatic merge from submit-queue Update README.md **Release note**: ```release-note None ``` Former-commit-id: b2fa60b
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
…729) * Add KUBECONFIG environment variable handling to kubernetes adapter. This PR primarily adds handling to kubernetes adapter to take the value for kubeconfigPath from mixer config as well as from environmental config (via the KUBECONFIG env var). NOTE: this configuration was previously available with via KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT env vars. This PR consolidates that into the Istio standard KUBECONFIG env var to harmonize deployment across componenets. Tested with out-of-the-box config via: ```bash $ KUBECONFIG=~/.kube/config bazel-bin/cmd/server/mixs server --configStoreURL=fs://$(pwd)/testdata/configroot --logtostderr -v=5 ``` and several client calls, as follows: ```bash $ bazel-bin/cmd/client/mixc report -v=45 -a target.service=foo.default.svc.cluster.local --string_attributes source.uid=kubernetes://productpage-v1-2087264475-bl9f2.default -m localhost:9091 --trace Report RPC returned OK Attribute Type Value source.labels map[string]string map[version:v1 app:productpage pod-template-hash:2087264475] source.name string productpage-v1-2087264475-bl9f2 source.namespace string default source.service string productpage.default.svc.cluster.local source.serviceAccount string default ``` * add override test bit Former-commit-id: 8e423f4949841158126b37050cf64e6c7919fbf5
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
Automatic merge from submit-queue Update README.md **Release note**: ```release-note None ``` Former-commit-id: b2fa60b
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
Automatic merge from submit-queue Update README.md **Release note**: ```release-note None ``` Former-commit-id: b2fa60b
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* update translate config * fix test and address comment * fix lint
0x01001011
pushed a commit
to thedemodrive/istio
that referenced
this pull request
Jul 16, 2020
* add enable_sds_k8s_sa_jwt flag to meshconfig * fix build * update comment and rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: