Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Update mock redis to improve test coverage. #537

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Update mock redis to improve test coverage. #537

merged 2 commits into from
Apr 12, 2017

Conversation

chowchow316
Copy link
Contributor

@chowchow316 chowchow316 commented Apr 12, 2017 •
edited by mandarjog
Loading

Added a time machine in mock redis (have a PR under review). The unit test now can cover expiring keys.
Keep working on improve code coverage now...

This change is Reviewable

@istio-testing
Copy link
Contributor

Jenkins job mixer/presubmit passed

@istio-testing
Copy link
Contributor

Jenkins job mixer/e2e-smoketest passed

1 similar comment
@istio-testing
Copy link
Contributor

Jenkins job mixer/e2e-smoketest passed

@istio-testing
Copy link
Contributor

Jenkins job mixer/manager-regression passed

@codecov
Copy link

codecov bot commented Apr 12, 2017 •
edited
Loading

Codecov Report

Merging #537 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #537      +/-   ##
=========================================
+ Coverage   88.51%   88.7%   +0.19%     
=========================================
  Files          57      57              
  Lines        3135    3135              
=========================================
+ Hits         2775    2781       +6     
+ Misses        315     307       -8     
- Partials       45      47       +2
Impacted Files Coverage Δ
adapter/redisquota/redisquota.go 64% <ø> (+6.39%) ⬆️
adapter/prometheus/server.go 90.47% <0%> (-9.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe979a...810fcac. Read the comment docs.

@istio-testing
Copy link
Contributor

Jenkins job mixer/manager-regression passed

geeknoid
geeknoid approved these changes Apr 12, 2017
View reviewed changes
CMakeLists.txt Outdated
@@ -0,0 +1,684 @@
cmake_minimum_required(VERSION 3.6)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from the PR. You could list this file in .gitgnore if that would be helpful to you in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@istio-testing
Copy link
Contributor

Jenkins job mixer/presubmit passed

1 similar comment
@istio-testing
Copy link
Contributor

Jenkins job mixer/presubmit passed

@istio-testing
Copy link
Contributor

Jenkins job mixer/e2e-smoketest passed

@istio-testing
Copy link
Contributor

Jenkins job mixer/manager-regression passed

@istio-testing
Copy link
Contributor

Jenkins job mixer/e2e-smoketest passed

@chowchow316 chowchow316 merged commit 2e6870d into istio:master Apr 12, 2017
@istio-testing
Copy link
Contributor

Jenkins job mixer/manager-regression passed

@chowchow316 chowchow316 mentioned this pull request Apr 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geeknoid geeknoid geeknoid approved these changes

@wenchenglu wenchenglu Awaiting requested review from wenchenglu

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chowchow316 @istio-testing @geeknoid @googlebot