-
Notifications
You must be signed in to change notification settings - Fork 93
Update mock redis to improve test coverage. #537
Conversation
5c660cf
to
2baad15
Compare
2baad15
to
87e6378
Compare
Jenkins job mixer/presubmit passed |
Jenkins job mixer/e2e-smoketest passed |
1 similar comment
Jenkins job mixer/e2e-smoketest passed |
Jenkins job mixer/manager-regression passed |
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=========================================
+ Coverage 88.51% 88.7% +0.19%
=========================================
Files 57 57
Lines 3135 3135
=========================================
+ Hits 2775 2781 +6
+ Misses 315 307 -8
- Partials 45 47 +2
Continue to review full report at Codecov.
|
Jenkins job mixer/manager-regression passed |
CMakeLists.txt
Outdated
@@ -0,0 +1,684 @@ | |||
cmake_minimum_required(VERSION 3.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from the PR. You could list this file in .gitgnore if that would be helpful to you in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Jenkins job mixer/presubmit passed |
1 similar comment
Jenkins job mixer/presubmit passed |
Jenkins job mixer/e2e-smoketest passed |
Jenkins job mixer/manager-regression passed |
Jenkins job mixer/e2e-smoketest passed |
Jenkins job mixer/manager-regression passed |
Added a time machine in mock redis (have a PR under review). The unit test now can cover expiring keys.
Keep working on improve code coverage now...
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)