This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Filter ingress ports #885
Merged
Filter ingress ports #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsnellf
commented
Jun 19, 2017
| @@ -10,13 +10,13 @@ import ( | |||
| "github.com/golang/glog" | |||
| ) | |||
|
|
|||
| func resolveStatsdAddr(statsdAdrr string) (string, error) { | |||
| if statsdAdrr == "" { | |||
| func resolveStatsdAddr(statsdAddr string) (string, error) { | |||
|
Jenkins job pilot/presubmit passed |
rshriram
reviewed
Jun 19, 2017
| @@ -276,6 +276,9 @@ func buildIngressRoute(ingress *proxyconfig.IngressRule, | |||
| if err != nil { | |||
| return nil, "", err | |||
| } | |||
| if servicePort.Protocol != model.ProtocolHTTP { | |||
There was a problem hiding this comment.
Ingress is only for HTTP traffic in-cluster. It may expose HTTPS on the front side, but that's irrelevant here.
| @@ -10,13 +10,13 @@ import ( | |||
| "github.com/golang/glog" | |||
| ) | |||
|
|
|||
| func resolveStatsdAddr(statsdAdrr string) (string, error) { | |||
| if statsdAdrr == "" { | |||
| func resolveStatsdAddr(statsdAddr string) (string, error) { | |||
kyessenov
approved these changes
Jun 19, 2017
|
Disregard e2e failures, the test is broken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out non-HTTP ingress ports. This should fix the Envoy crashing observed in istio/old_issues_repo#20. Instead, Pilot will log a warning.