-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
@@ -10,13 +10,13 @@ import ( | |||
"github.com/golang/glog" | |||
) | |||
|
|||
func resolveStatsdAddr(statsdAdrr string) (string, error) { | |||
if statsdAdrr == "" { | |||
func resolveStatsdAddr(statsdAddr string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Why remove the if block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore
Jenkins job pilot/presubmit passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about https?
@@ -276,6 +276,9 @@ func buildIngressRoute(ingress *proxyconfig.IngressRule, | |||
if err != nil { | |||
return nil, "", err | |||
} | |||
if servicePort.Protocol != model.ProtocolHTTP { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingress is only for HTTP traffic in-cluster. It may expose HTTPS on the front side, but that's irrelevant here.
@@ -10,13 +10,13 @@ import ( | |||
"github.com/golang/glog" | |||
) | |||
|
|||
func resolveStatsdAddr(statsdAdrr string) (string, error) { | |||
if statsdAdrr == "" { | |||
func resolveStatsdAddr(statsdAddr string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore
Disregard e2e failures, the test is broken. |
Filter out non-HTTP ingress ports. This should fix the Envoy crashing observed in istio/old_issues_repo#20. Instead, Pilot will log a warning.