Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor_version for build info #368

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shamsher31
Copy link
Member

@shamsher31 shamsher31 self-assigned this Jun 15, 2021
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 15, 2021
@istio-policy-bot
Copy link

😊 Welcome @shamsher31! This is either your first contribution to the Istio pkg repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 15, 2021
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO "vendor version" should not be a concept. For example:

"serverVersion": {
    "major": "1",
    "minor": "20+",
    "gitVersion": "v1.20.6-gke.1400",
    "gitCommit": "b7ccf3218bdb80cd2d66ed6186d78f18f1ef03c6",
    "gitTreeState": "clean",
    "buildDate": "2021-05-05T09:19:45Z",
    "goVersion": "go1.15.10b5",
    "compiler": "gc",
    "platform": "linux/amd64"
  }

GKE k8s version. The "vendor" aspect is just in the normal version

@mandarjog
Copy link
Contributor

@shamsher31 in the build if VERSION is set it is used to link stamp binaries. We will now set that VERsIOn to the full version including Google specific extensions. Like 1.10.2-asm.5

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 10, 2022
@istio-testing
Copy link
Contributor

@shamsher31: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants