Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genjobs: update docs, create Dockerfile, autodeploy #2163

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Genjobs: update docs, create Dockerfile, autodeploy #2163

merged 2 commits into from
Dec 14, 2019

Conversation

clarketm
Copy link
Member

@clarketm clarketm commented Nov 28, 2019 •
edited

  1. update installation and usage documentation.
  2. create Dockerfile and start publishing images.
  3. add go.mod and make submodule for smaller images and modular build.
  4. add autodeploy jobs to publish docker images.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 28, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 28, 2019
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 28, 2019
@clarketm clarketm force-pushed the genjobs-docs branch 6 times, most recently from 25f0db4 to 2b547da Compare November 28, 2019 07:58
@clarketm clarketm marked this pull request as ready for review November 28, 2019 08:04
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 28, 2019
@clarketm clarketm force-pushed the genjobs-docs branch 3 times, most recently from e67bf71 to 57479ed Compare November 28, 2019 10:52
fejta
fejta reviewed Dec 7, 2019
View reviewed changes
prow/cluster/jobs/istio/test-infra/istio.test-infra.trusted.master.yaml Outdated Show resolved Hide resolved
prow/config.yaml Outdated Show resolved Hide resolved
prow/genjobs/README.md Outdated Show resolved Hide resolved
prow/genjobs/go.mod Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 7, 2019
@clarketm clarketm changed the title Genjobs: update docs, create Dockerfile, and make go submodule Genjobs: update docs, create Dockerfile Dec 7, 2019
@clarketm clarketm force-pushed the genjobs-docs branch 4 times, most recently from 6e0ef34 to 18a2345 Compare December 11, 2019 18:15
@clarketm clarketm requested a review from fejta December 11, 2019 18:17
@clarketm clarketm mentioned this pull request Dec 11, 2019
Open
@clarketm
Copy link
Member Author

@fejta
PTAL. I have resolved all the suggestions and will look more into GCB as an alternative for these types of jobs #2211.

@clarketm clarketm changed the title Genjobs: update docs, create Dockerfile Genjobs: update docs, create Dockerfile, autodeploy Dec 13, 2019
fejta
fejta approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Dec 14, 2019
@clarketm clarketm removed the do-not-merge/hold Block automatic merging of a PR. label Dec 14, 2019
@istio-testing istio-testing merged commit 1cac738 into istio:master Dec 14, 2019
@istio-testing
Copy link
Collaborator

@clarketm: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key istio.test-infra.master.gen.yaml using file prow/cluster/jobs/istio/test-infra/istio.test-infra.master.gen.yaml

In response to this:

  1. update installation and usage documentation.
  2. create Dockerfile and start publishing images.
  3. add go.mod and make submodule for smaller images and modular build.
  4. add autodeploy jobs to publish docker images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clarketm clarketm deleted the genjobs-docs branch February 13, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@Katharine Katharine Awaiting requested review from Katharine

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@howardjohn howardjohn

@michelle192837 michelle192837

@fejta fejta

@cjwagner cjwagner

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@clarketm @istio-testing @fejta @howardjohn @michelle192837 @cjwagner @googlebot