deps: use cuelang.org/go@v0.4.0 #1539
Conversation
|
😊 Welcome @myitcv! This is either your first contribution to the Istio tools repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
google-cla
bot
added
the
cla: yes
istio-testing
added
size/M
|
Hi @myitcv. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change is the result of regenerating using the version of cuelang.org/go implied by istio/tools#1539.
|
Please see the commentary in istio/api#1999 (comment) which looks to explain the impact of this PR. cc @mpvl |
|
@myitcv Will there be an improvement of the speed during generating schemas using the new version of cue? |
|
@jasonwzm - thanks. Before we merge this PR we need to resolve a couple of issues in istio/api#1999. I'm working on something that @howardjohn caught.
We should be able to confirm more precisely when we resolve all the issues in istio/api#1999 😄 Our plan is to integrate the Istio project into our regression test corpus (https://github.com/cue-sh/unity) so that a) we don't regress against your usage of the API, and b) we can track (roughly, initially) the performance impact of changes. Integrating Istio is a bit trickier because we can't currently resolve the version of the this repo from a given commit of the api repo. But we can perhaps revisit that question once we have resolved all the issues and merge this PR and istio/api#1999. |
|
/ok-to-test |
istio-testing
added
ok-to-test
myitcv
changed the title
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
This change is the result of regenerating using the version of cuelang.org/go implied by istio/tools#1539.
There was a problem hiding this comment.
LGTM as does the API PR. Thanks for the PRs! Do you mind waiting until we resolve istio/istio#32985 before merging? We are investigating massive increase in test failures and want to minimize changes to the build image to reduce the number of variables.
No problem at all, and thanks for looking at this so promptly. We can't merge this yet in any case for two reasons:
So, very happy for this to remain on hold. I will give a 👍 when things look good from our side. |
myitcv
force-pushed
the
deps_cue_v0.3.2
branch
3 times, most recently
from
b348678
to
4159a24
Compare
istio-testing
added
size/L
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
|
@howardjohn we have just released CUE For now I've simply added So this PR is now good to go from my perspective. istio/api#1999 is also ready therefore and I will add a comment there to that effect. |
|
/retest |
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
The current version of cuelang.org/go (76252f4b7486) is now more than a year old. Since then, there have been significant improvements to performance and correctness as part of a rewrite of the evaluation engine. This change bumps the tools repo to the latest stable version of CUE, v0.4.0. Also: * Make the iteration of directories stable in order to make debugging issues simpler. * Do not swallow JSON marshal errors when generating the resulting openapi files. * Handle change in labels now that definitions are prefixed with '#' * Properly construct relative path to allow api to be regenerated with a working directory of the tool repo (as a sibling of the api repo) * Result of 'make gen' that adds new license files as a result of transitive dependencies bumping with the move to cuelang.org/go@v0.4.0 A fix to drop the uses of nolint:staticcheck and upgrade Istio to use non-deprecated parts of the CUE API will follow in a later PR.
deps: use cuelang.org/go@v0.4.0
The current version of cuelang.org/go (76252f4b7486) is now more than a
year old. Since then, there have been significant improvements to
performance and correctness as part of a rewrite of the evaluation
engine.
This change bumps the tools repo to the latest stable version of CUE,
v0.4.0.
Also:
issues simpler.
openapi files.
a working directory of the tool repo (as a sibling of the api repo)
transitive dependencies bumping with the move to cuelang.org/go@v0.4.0
A fix to drop the uses of nolint:staticcheck and upgrade Istio to use
non-deprecated parts of the CUE API will follow in a later PR.