dns: fix headless service handling #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we treated any service without a VIP as headless. This is not
correct. Consider
```yaml
apiVersion: networking.istio.io/v1
kind: ServiceEntry
metadata:
name: external
hosts:
- httpbin.org
location: MESH_EXTERNAL
ports:
- number: 80
name: http
resolution: DNS
```
We should NOT treat this as headless.
The implementation is a total hack, but a better fix requires WDS
changes so for now a short approach is best
howardjohn
added
release-notes-none
istio-testing
added
the
size/L
ilrudie
reviewed
May 15, 2024
src/dns/server.rs
Outdated
| // Domain will be like `.svc.cluster.local.` (trailing .), so ignore the last character. | ||
| let domain = self.svc_domain.to_utf8(); | ||
| !service.vips.is_empty() | ||
| || service.hostname.ends_with(&domain[..domain.len() - 1]) |
There was a problem hiding this comment.
Should we use strip_suffix(...).expect("the svc domain must have a trailing '.'") which is a firmer assertion of the form of the svc_domain since malformed will cause a panic but won't quietly behave badly if our assumptions were false.
howardjohn
force-pushed
the
dns/fix-headless
branch
from
952c855
to
d83525c
Compare
howardjohn
force-pushed
the
dns/fix-headless
branch
from
d83525c
to
ff5e62d
Compare
|
In response to a cherrypick label: new pull request created: #1058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we treated any service without a VIP as headless. This is not
correct. Consider
We should NOT treat this as headless.
The implementation is a total hack, but a better fix requires WDS
changes so for now a short approach is best
Fixes #909
Fixes #554