Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: really, really stop nagle's algorithm #1062

Merged
merged 1 commit into from
May 16, 2024

Conversation

howardjohn
Copy link
Member

Take 4? This time I made it so its very very hard to forget

Take 4? This time I made it so its very very hard to forget
@howardjohn howardjohn requested a review from a team as a code owner May 16, 2024 17:45
@howardjohn howardjohn added release-notes-none Indicates a PR that does not require release notes. cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch labels May 16, 2024
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2024
self.configure(tokio::net::TcpSocket::new_v4)
self.configure(|| {
TcpSocket::new_v4().and_then(|s| {
s.set_nodelay(true)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is cleaner either way, no reason to let the handlers have the opportunity to not set this.

@istio-testing istio-testing merged commit 917481b into istio:master May 16, 2024
3 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: #1062 failed to apply on top of branch "release-1.22":

Applying: perf: really, really stop nagle's algorithm
Using index info to reconstruct a base tree...
M	src/proxy.rs
M	src/proxy/inbound.rs
M	src/proxy/outbound.rs
M	src/proxy/pool.rs
Falling back to patching base and 3-way merge...
Auto-merging src/proxy/pool.rs
Auto-merging src/proxy/outbound.rs
Auto-merging src/proxy/inbound.rs
CONFLICT (content): Merge conflict in src/proxy/inbound.rs
Auto-merging src/proxy.rs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 perf: really, really stop nagle's algorithm
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@istio-testing
Copy link
Contributor

In response to a cherrypick label: new issue created for failed cherrypick: #1063

istio-testing pushed a commit that referenced this pull request May 16, 2024
Take 4? This time I made it so its very very hard to forget

(cherry picked from commit 917481b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants