-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: really, really stop nagle's algorithm #1062
Conversation
Take 4? This time I made it so its very very hard to forget
self.configure(tokio::net::TcpSocket::new_v4) | ||
self.configure(|| { | ||
TcpSocket::new_v4().and_then(|s| { | ||
s.set_nodelay(true)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is cleaner either way, no reason to let the handlers have the opportunity to not set this.
In response to a cherrypick label: #1062 failed to apply on top of branch "release-1.22":
|
In response to a cherrypick label: new issue created for failed cherrypick: #1063 |
Take 4? This time I made it so its very very hard to forget