Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add cargo deny to check for CVEs & allowed licenses #280

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

hypernovasunnix
Copy link
Contributor

@hypernovasunnix hypernovasunnix commented Dec 15, 2022

Creates two new targets (cve-check & license-check) that utilizes cargo-deny.
cve-check will check for any CVEs in all deps (currently there in one)
license-check uses the deny.toml to scan for allowed licenses

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 15, 2022
@google-cla
Copy link

google-cla bot commented Dec 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Dec 15, 2022
@istio-testing
Copy link
Contributor

Hi @hypernovasunnix. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@keithmattix
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 15, 2022
allow.toml Outdated Show resolved Hide resolved
Makefile.core.mk Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2022
deny.toml Outdated Show resolved Hide resolved
@hypernovasunnix hypernovasunnix changed the title [WIP] (feat) Add cargo audit on presubmit and add allow list licenses (feat) Add cargo audit on presubmit and add allow list licenses Dec 15, 2022
@hypernovasunnix hypernovasunnix marked this pull request as ready for review December 15, 2022 22:39
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2022
@hypernovasunnix hypernovasunnix changed the title (feat) Add cargo audit on presubmit and add allow list licenses (feat) Add cargo deny on presubmit and add allow list licenses Dec 16, 2022
@hypernovasunnix hypernovasunnix changed the title (feat) Add cargo deny on presubmit and add allow list licenses (feat) Add cargo deny to check for CVEs & allowed licenses Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants