Fix for DNS system forwarder #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
nmittler
force-pushed
the
dns
branch
2 times, most recently
from
a0b909a
to
b0bd454
Compare
|
resolves #600 ? |
nmittler
force-pushed
the
dns
branch
2 times, most recently
from
8355452
to
da66319
Compare
istio-testing
added
size/L
kdorosh
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
changes lgtm, also confirmed it fixes the istio integration test error istio/istio#45900 (comment)
Currently, if a DNS request is forwarded to the upstream resolver and fails with NXDomain, the client will see a successful response with no records. This is due to the fact that the DNS system forwarder returns an error of type ResolveError, which was not being handled properly by the Handler. This fixes the logic and adds tests for the system forwarder. Fixes istio#600
Closed
howardjohn
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a DNS request is forwarded to the upstream resolver and fails with NXDomain, the client will see a successful response with no records.
This is due to the fact that the DNS system forwarder returns an error of type ResolveError, which was not being handled properly by the Handler.
This fixes the logic and adds tests for the system forwarder.
Fixes #600