Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

165 implementierung von konfiguration wahltag #244

Merged
merged 44 commits into from
May 21, 2024
Merged

165 implementierung von konfiguration wahltag #244

merged 44 commits into from
May 21, 2024

Conversation

dragonfly28
Copy link
Contributor

@dragonfly28 dragonfly28 commented May 16, 2024 •
edited by MrSebastian
Loading

Beschreibung:

Beschreben Sie hier die wesentlichen Aufgaben, die damit erledigt wurden und geben sie Hinweise zum Review.

Definition of Done (DoD):

Backend

  • Swagger-API vollständig
  • Unit-Tests gepflegt
  • Integrationstests gepflegt
  • Beispiel-Requests gepflegt

Referenzen1:

Closes #165

Footnotes

  1. Nicht zutreffende Referenzen vor dem Speichern entfernen ↩

@dragonfly28 dragonfly28 linked an issue May 16, 2024 that may be closed by this pull request
Implementierung von Konfiguration Wahltag #165
Closed
6 tasks
@MrSebastian MrSebastian self-assigned this May 16, 2024
MrSebastian
MrSebastian requested changes May 17, 2024
View reviewed changes
Copy link
Member

@MrSebastian MrSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht sehr gut aus. Es fehlt ein Test, ein paar Parameter sollten anders sein. Ansonmsten gibt es einige Optimierungsmöglichkeiten und hauptsächlich ein paar Leerzeilen aus meiner Sicht zu viel.

wls-infomanagement-service/pom.xml Outdated Show resolved Hide resolved
...muenchen/oss/wahllokalsystem/infomanagementservice/domain/wahltag/KonfigurierterWahltag.java Outdated Show resolved Hide resolved
...muenchen/oss/wahllokalsystem/infomanagementservice/domain/wahltag/KonfigurierterWahltag.java Outdated Show resolved Hide resolved
...en/oss/wahllokalsystem/infomanagementservice/service/wahltag/KonfigurierterWahltagModel.java Outdated Show resolved Hide resolved
.../wahllokalsystem/infomanagementservice/service/wahltag/KonfigurierterWahltagModelMapper.java Show resolved Hide resolved
.../wahllokalsystem/infomanagementservice/rest/wahltag/KonfigurierterWahltagControllerTest.java Outdated Show resolved Hide resolved
.../wahllokalsystem/infomanagementservice/rest/wahltag/KonfigurierterWahltagControllerTest.java Outdated Show resolved Hide resolved
.../wahllokalsystem/infomanagementservice/rest/wahltag/KonfigurierterWahltagControllerTest.java Show resolved Hide resolved
.../oss/wahllokalsystem/infomanagementservice/service/wahltag/KonfigurierterWahltagService.java Outdated Show resolved Hide resolved
.../oss/wahllokalsystem/infomanagementservice/service/wahltag/KonfigurierterWahltagService.java Outdated Show resolved Hide resolved
MrSebastian and others added 18 commits May 17, 2024 09:20
@MrSebastian
remove unnecessary annotation
fce2270
@MrSebastian
add unit test for KonfigurierterWahltagModelMapper
9b72547
@dragonfly28
Leerzeile raus
f25b01d
@MrSebastian
use spring data to update wahltage to inaktive
d47b424
@MrSebastian
update tests for new update method in repository
0694638
@MrSebastian
remove empty lines add the beginning of methods
c1a2361
@MrSebastian
remove empty lines add the beginning of methods
1446945
@MrSebastian
review feedback - improve test name
0d3a1b2
@MrSebastian
Merge remote-tracking branch 'origin/165-implementierung-von-konfigur…
1703a71 
…ation-wahltag' into 165-implementierung-von-konfiguration-wahltag
@MrSebastian
review feedback: use val
f247aed
@MrSebastian
refactor status to active in model and entity
d8916d7
@MrSebastian
remove unused var
2eb8391
@MrSebastian
remove empty line
7a4f3b0
@MrSebastian
remove unnecessary annotation
e9ba827
@MrSebastian
remove empty line
59279cc
@MrSebastian
reduce api overhead: ID instead of model
a7b138f
@MrSebastian
remove wrong placed comment
3c6495a
@MrSebastian
let sort by wahltag asc done via hibernate
c459bd2
@MrSebastian MrSebastian marked this pull request as draft May 17, 2024 15:16
@MrSebastian MrSebastian marked this pull request as ready for review May 17, 2024 15:16
@MrSebastian MrSebastian mentioned this pull request May 17, 2024
Merged
5 tasks
GerhardPx
GerhardPx approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@GerhardPx GerhardPx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus, keine weiteren Anmerkungen. Die einzigen Fragen haben sich dann in der IDE erübrigt.

@MrSebastian MrSebastian merged commit 9a1651a into dev May 21, 2024
4 checks passed
@MrSebastian MrSebastian deleted the 165-implementierung-von-konfiguration-wahltag branch May 21, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSebastian MrSebastian MrSebastian approved these changes

@GerhardPx GerhardPx GerhardPx approved these changes

Assignees

@MrSebastian MrSebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementierung von Konfiguration Wahltag
3 participants
@dragonfly28 @MrSebastian @GerhardPx