Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/doctor-preview-test #51

Merged
merged 42 commits into from
Nov 16, 2020
Merged

Feature/doctor-preview-test #51

merged 42 commits into from
Nov 16, 2020

Conversation

AntonMishyn
Copy link
Contributor

@AntonMishyn AntonMishyn commented Nov 15, 2020 •
edited
Loading

develop

GitHub Board

Issue link

#34 BE - doctors preview task (main page)

Story link

#13 Story

Code reviewers

Summary of issue

    • DTO for doctor (and latest post from him)
    • API (POST) controller with request configuration
    • Service layer
    • Repository layer (sort by making posts)
    • Unit tests

Summary of change

  • Refactor Entities
  • Implement UnitTests for UserController, mappers, UserService.

AntonMishyn and others added 30 commits November 4, 2020 12:17
@AntonMishyn
Fetch types optimized
28feb70
@AntonMishyn
Merge branch 'develop' of https://github.com/ita-social-projects/doka…
8c7d7de 
…zovi-be into develop
@AntonMishyn
Entity fetch types optimized, Lombok lib added to dependencies, lombo…
81606dd 
…k annotations used on Entities
@AntonMishyn
Merge branch 'develop' of https://github.com/ita-social-projects/doka…
8df2209 
…zovi-be into develop
@AntonMishyn
Merge branch 'develop' of https://github.com/ita-social-projects/doka…
3a1c0b5 
…zovi-be into develop
@ponruslan
Write PostDTO, PostTypeDTO, PostUserDTO.
e5fa497 
Write mappers for these DTOs.
Write endpoint to search for post by status.
Add required methods in PostService and PostRepository.
Switch Swagger DocumentationType to OpenAPI3.
@AntonMishyn
Created DTO for doctor preview, extended userEntity with avatar url.
d19e184
@ponruslan
Add String field "avatar" to UserEntity, add migration to it.
f6fd6a1
@ponruslan
delete argument in "/latest" endpoint
f77e84a
@ponruslan
Rename mappers, change api description in controller
23fd288
@ponruslan
add date formatting to created_At field in LatestPostDTO
c631cb3
@AntonMishyn
merged feature/latest_posts
b292796
@AntonMishyn
Merge remote-tracking branch 'central/feature/latest_posts' into feat…
24c415f 
…ure/doctor-preview

# Conflicts:
#	src/main/java/com/softserveinc/dokazovi/mapper/DirectionMapper.java
#	src/main/java/com/softserveinc/dokazovi/mapper/InstitutionMapper.java
#	src/main/java/com/softserveinc/dokazovi/mapper/UserMapper.java
#	src/main/java/com/softserveinc/dokazovi/repositories/PostRepository.java
@AntonMishyn
Added DB migration
3dab202
@AntonMishyn
Minor tweaks
90ec48b
@AntonMishyn
Corrected mapping
e3aa80a
@AntonMishyn
Migration implemented, controller, dto, mapping, repository
7bcefb5
@AntonMishyn
Merged with dev
dafdb3e
@andrewtyshkovets
Implemented UserService expert preview. Minor userController changes
99d44a6
@andrewtyshkovets
Cleared UserService imports
6bb8679
@AntonMishyn
Implemented UserService method getExpertsPreview
adfc230
@AntonMishyn
Improved endpoint
f519255
@AntonMishyn
Merge branch 'develop' of https://github.com/ita-social-projects/doka…
f70c342 
…zovi-be into develop
@AntonMishyn
Improved controller mapping
b54cd12
@AntonMishyn
Merged with develop
fd5a1db
@AntonMishyn
Project.xml fix
8db7578
@AntonMishyn
Merge branch 'develop' of https://github.com/ita-social-projects/doka…
f3a3e89 
…zovi-be into develop
@AntonMishyn
Expert preview implementation for new DB structure
ea294d0
@AntonMishyn
Merge branch 'develop' into feature/doctor-preview
206650b
@AntonMishyn
Test Checkstyle set-up
a03b15d
ponruslan
ponruslan requested changes Nov 15, 2020
View reviewed changes
src/main/java/com/softserveinc/dokazovi/entity/DirectionEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/DirectionEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/DirectionEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/DirectionEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/InstitutionEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/UserEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/UserEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/UserEntity.java Outdated Show resolved Hide resolved
src/main/java/com/softserveinc/dokazovi/entity/UserEntity.java Outdated Show resolved Hide resolved
src/test/java/com/softserveinc/dokazovi/mapper/UserMapperTest.java Outdated Show resolved Hide resolved
This was linked to issues Nov 15, 2020
BE - doctors preview task (main page) #34
Closed
As a user (any role) I want to view the pictures of experts in "Experts" section so that I will know what the doctor looks like. #13
Closed
@AntonMishyn AntonMishyn merged commit 4717c7b into develop Nov 16, 2020
@AntonMishyn AntonMishyn deleted the feature/doctor-preview-test branch November 16, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melnikovae87 melnikovae87 melnikovae87 approved these changes

@ponruslan ponruslan ponruslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@AntonMishyn @melnikovae87 @ponruslan @andrewtyshkovets