Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #75

Merged
merged 158 commits into from
Nov 25, 2020
Merged

Master #75

merged 158 commits into from
Nov 25, 2020

Conversation

SergeOlabin
Copy link
Collaborator

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

SergeOlabin and others added 28 commits November 19, 2020 16:16
* add material ui icons and font

* add reset styles

* changed header

* update carousel

* fix card full name

* update PostPreviewCard styles

* update MainView layout

* update NewesContainer

* add lib comp for border split

* add Border comp to other comps

Co-authored-by: Gtes <gates1993@gmail.com>
* added action for PR on develop (#57)

* added action for PR on develop

* fix npm install

* clear ci true flag

* fix npm build

* change jsx field in tsconfig.json

* change back jsx field in tsconfig.json

* change npm ci to npm i in  cy-develop.yml

* disable rules in modules/main/store/actions.ts

* change back actions.ts in main and clear npm run build field in c-develop.yml

* bring back npm run build to ci-develop.yml

* added different versions of node to yml config

* delete 15.x node

* delete 14.x node version

* delete 13.x node and add --if-present flag

* #26 add testing for experts (#43)

* #26 add testing for experts

* #26 delete not needed babel introduction

* #26 delete empty lines

* #26 fix hardcoded experts amount

* #26 add new test

* #26 refactor

* #26 add test to count number of expertBlocks

* #26 add test to count number of expertBlocks

* #26 refactor

* #26 add title experts and one more test

* Action on dev (#60)

* added action for PR on develop

* fix npm install

* clear ci true flag

* fix npm build

* change jsx field in tsconfig.json

* change back jsx field in tsconfig.json

* change npm ci to npm i in  cy-develop.yml

* disable rules in modules/main/store/actions.ts

* change back actions.ts in main and clear npm run build field in c-develop.yml

* bring back npm run build to ci-develop.yml

* added different versions of node to yml config

* delete 15.x node

* delete 14.x node version

* delete 13.x node and add --if-present flag

* added ci false flag to yml config

* locked ts minor version

Co-authored-by: Serhii Olabin <serge.olabin@gmail.com>

* Issue 41 redux toolkit (#55)

* configure root store & reducer, convert mainReducer into a slice

* update Important Container

* update MainExpertsView, main reducers & mock data

* remove unneeded files

* extract rootReducer into separate module for clarity

* add reusable thunk function type

* provide a thunk for important

* provide a thunk to fetch experts

* update state for Newest component

* provide a thunk to fetch newest items

* remove unneeded files

* make type imports explicit to avoid import/no-cycle error

* clear comments

* fix type name

* remove unneeded file

* add type naming eslint rule, fix more types

* fix type naming

Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com>

* Issue 61 fix expert popover (#62)

* fix: ExpertDataCard

* fix: ExpertPopover

* fix: MainExpertsView style

* fix: ExpertDataCard

* fix: ExpertDataCard

* Header branch (#58)

* changes at app.tsx

* header logic and material ua styles

* change header logic and styles

* change logic and styles

* change styles and header logic

* change logic

* change logic and delete dropdown menu

* delete component ListItems

* add sonar scan plus jest code coverage (#65)

* add sonar scan plus jest code coverage

* fix env field in ci develop yml

* trigger gh action

* trigger action again

* make separate action for sonar

* change readme

* fix readme

* make a separate workflow for assemble

* fix incorrect branches field in release.yml

* fix indents in release yml

* create a single script command on package json

* integrate coverage script and clear unnecessary yml configs

Co-authored-by: Anton Gluschuk <32397351+AntonGluschuk@users.noreply.github.com>
Co-authored-by: Tetiana Polishchuk <57040275+tania833@users.noreply.github.com>
Co-authored-by: Alexander <63422553+calster00@users.noreply.github.com>
Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com>
Co-authored-by: Yaroslav Zaychenko <66166679+DelFlumen@users.noreply.github.com>
Co-authored-by: Darya Solomakha <56520654+darya42185@users.noreply.github.com>
@SergeOlabin SergeOlabin changed the title Mater Master Nov 25, 2020
@SergeOlabin SergeOlabin merged commit 5406d5b into master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants