Experts: unit testing #26
Comments
tania833
added a commit
that referenced
this issue
Nov 19, 2020
tania833
added a commit
that referenced
this issue
Nov 19, 2020
tania833
added a commit
that referenced
this issue
Nov 19, 2020
tania833
added a commit
that referenced
this issue
Nov 19, 2020
tania833
added a commit
that referenced
this issue
Nov 19, 2020
5 tasks
5 tasks
5 tasks
tania833
added a commit
that referenced
this issue
Nov 20, 2020
SergeOlabin
pushed a commit
that referenced
this issue
Nov 20, 2020
* #26 add testing for experts * #26 delete not needed babel introduction * #26 delete empty lines * #26 fix hardcoded experts amount * #26 add new test * #26 refactor * #26 add test to count number of expertBlocks * #26 add test to count number of expertBlocks * #26 refactor * #26 add title experts and one more test
SergeOlabin
added a commit
that referenced
this issue
Nov 25, 2020
* added action for PR on develop (#57) * added action for PR on develop * fix npm install * clear ci true flag * fix npm build * change jsx field in tsconfig.json * change back jsx field in tsconfig.json * change npm ci to npm i in cy-develop.yml * disable rules in modules/main/store/actions.ts * change back actions.ts in main and clear npm run build field in c-develop.yml * bring back npm run build to ci-develop.yml * added different versions of node to yml config * delete 15.x node * delete 14.x node version * delete 13.x node and add --if-present flag * #26 add testing for experts (#43) * #26 add testing for experts * #26 delete not needed babel introduction * #26 delete empty lines * #26 fix hardcoded experts amount * #26 add new test * #26 refactor * #26 add test to count number of expertBlocks * #26 add test to count number of expertBlocks * #26 refactor * #26 add title experts and one more test * Action on dev (#60) * added action for PR on develop * fix npm install * clear ci true flag * fix npm build * change jsx field in tsconfig.json * change back jsx field in tsconfig.json * change npm ci to npm i in cy-develop.yml * disable rules in modules/main/store/actions.ts * change back actions.ts in main and clear npm run build field in c-develop.yml * bring back npm run build to ci-develop.yml * added different versions of node to yml config * delete 15.x node * delete 14.x node version * delete 13.x node and add --if-present flag * added ci false flag to yml config * locked ts minor version Co-authored-by: Serhii Olabin <serge.olabin@gmail.com> * Issue 41 redux toolkit (#55) * configure root store & reducer, convert mainReducer into a slice * update Important Container * update MainExpertsView, main reducers & mock data * remove unneeded files * extract rootReducer into separate module for clarity * add reusable thunk function type * provide a thunk for important * provide a thunk to fetch experts * update state for Newest component * provide a thunk to fetch newest items * remove unneeded files * make type imports explicit to avoid import/no-cycle error * clear comments * fix type name * remove unneeded file * add type naming eslint rule, fix more types * fix type naming Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com> * Issue 61 fix expert popover (#62) * fix: ExpertDataCard * fix: ExpertPopover * fix: MainExpertsView style * fix: ExpertDataCard * fix: ExpertDataCard * Header branch (#58) * changes at app.tsx * header logic and material ua styles * change header logic and styles * change logic and styles * change styles and header logic * change logic * change logic and delete dropdown menu * delete component ListItems * add sonar scan plus jest code coverage (#65) * add sonar scan plus jest code coverage * fix env field in ci develop yml * trigger gh action * trigger action again * make separate action for sonar * change readme * fix readme * make a separate workflow for assemble * fix incorrect branches field in release.yml * fix indents in release yml * create a single script command on package json * integrate coverage script and clear unnecessary yml configs Co-authored-by: Anton Gluschuk <32397351+AntonGluschuk@users.noreply.github.com> Co-authored-by: Tetiana Polishchuk <57040275+tania833@users.noreply.github.com> Co-authored-by: Alexander <63422553+calster00@users.noreply.github.com> Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com> Co-authored-by: Yaroslav Zaychenko <66166679+DelFlumen@users.noreply.github.com> Co-authored-by: Darya Solomakha <56520654+darya42185@users.noreply.github.com>
SergeOlabin
added a commit
that referenced
this issue
Nov 25, 2020
* feat: add eslint & prettier * #4 add router with types * #4 delete not needed dependency * fix: temporarily disable git hooks for performance reasons pre-commit has to be swapped for pre-push * #4 return logo and App div * fix: tweak eslint rules, fix lint errors * Delete package-lock.json * fixed types * fix eslint issues * some lint adjustments * add interface for nested routes * refactor RenderRoutes * refactor Router empty lines * refactor single-quotes and empty lines * refactor empty lines types.ts * finalize router * prettier single quote * Delete package-lock.json * Update src/navigation/Router.tsx * setup redux * fix linter scripts in package.json * update linter run command * #14 add initial typing * Update issue templates Some update issue templates * fix names in directionReducer, move state interfaces to reducers * Update pull request template 1 * Update pull_request_template.md * Update pull_request_template.md * add header * folder renamings * resolve conflict * #14 refactor types.ts * add carousel component * #4 add preview type string * #14 delete not needed typing * add eslint interface naming rule (deactivated) * fix header remarks * fix lint error, re-enable interface naming rule * #17 provide element presentation component * #17 refactor types and add props * #22 add preview component * fix header remarks v2 * #22 refactoring experts * #22 refactor * #17 refactor IPost interface and mock-data.ts * #22 make expertblock for 1 expert * #22 resolve conflict with types * add basic grid * replace header to src/lib * implement css grid in the Experts * move style logic, rename and move files to main * feat: PostPreviewCard * add important container, modify actions & reducer * feat: add react-redux types, redux interfaces * feat: add mock data, pagination config * feat: add newest container, pagination logic for mock data * #24 initial logic with mocks * fix root state interface * #24 refactor with useDispatch * #24 translocate IRootState * move important container to the main view * move data fetching into loadImportant action creator * #24 refactor rootReducer * fix: PostPreviewCard * minor fix * #24 change IRootState interface and actions.ts * Update src/modules/main/components/ImportantContainer.tsx * Update src/App.tsx * #24 changed name for cards * import fixes * Merge branch 'develop' into issue_11_Lazy_loading-pagination_grid_view * updated NewestPosts mock data * moved data processing to redux * redux logic * #discussion_r524984890 fixed naming and spread array error * #discussion_r524983760 removed obsolete file * #discussion_r524985613 chage interface naming INewestPosts > INewestPostPayload * #discussion_r524988489 Refactoring logic for initial calculation. * #discussion_r524994007 change naming posts > newestPosts * #discussion_r524993548 change setting newestPosts * feat: ExpertPopover logic * add ci cd heroku with docker * comment action * fixed dockerfile and ci-cd-dev yml config * feat: ExpertDataCard * fix: ExpertPopover * fix: ExpertDataCard, direction-properties * skip test * change cicd dev yml * add npm i to yml config * fix ident * removed build on github action * removed lock-json logic * docker fix * branch added * changed port * changed nginx confg * 80:80 * changed port -> 3000 * change to 8084 8084 * 80:80 everywhere * change workdir * change back to 3000 * change prod env in docker file * trying ENV port var * trying to catch dynamic port from heroku * change docker compose ports field * delete from action test-docker branch * add material ui icons and font * add reset styles * changed header * update carousel * fix card full name * update PostPreviewCard styles * update MainView layout * update NewesContainer * add lib comp for border split * add Border comp to other comps * release (#59) * add material ui icons and font * add reset styles * changed header * update carousel * fix card full name * update PostPreviewCard styles * update MainView layout * update NewesContainer * add lib comp for border split * add Border comp to other comps Co-authored-by: Gtes <gates1993@gmail.com> * fixed not null * release (#72) * added action for PR on develop (#57) * added action for PR on develop * fix npm install * clear ci true flag * fix npm build * change jsx field in tsconfig.json * change back jsx field in tsconfig.json * change npm ci to npm i in cy-develop.yml * disable rules in modules/main/store/actions.ts * change back actions.ts in main and clear npm run build field in c-develop.yml * bring back npm run build to ci-develop.yml * added different versions of node to yml config * delete 15.x node * delete 14.x node version * delete 13.x node and add --if-present flag * #26 add testing for experts (#43) * #26 add testing for experts * #26 delete not needed babel introduction * #26 delete empty lines * #26 fix hardcoded experts amount * #26 add new test * #26 refactor * #26 add test to count number of expertBlocks * #26 add test to count number of expertBlocks * #26 refactor * #26 add title experts and one more test * Action on dev (#60) * added action for PR on develop * fix npm install * clear ci true flag * fix npm build * change jsx field in tsconfig.json * change back jsx field in tsconfig.json * change npm ci to npm i in cy-develop.yml * disable rules in modules/main/store/actions.ts * change back actions.ts in main and clear npm run build field in c-develop.yml * bring back npm run build to ci-develop.yml * added different versions of node to yml config * delete 15.x node * delete 14.x node version * delete 13.x node and add --if-present flag * added ci false flag to yml config * locked ts minor version Co-authored-by: Serhii Olabin <serge.olabin@gmail.com> * Issue 41 redux toolkit (#55) * configure root store & reducer, convert mainReducer into a slice * update Important Container * update MainExpertsView, main reducers & mock data * remove unneeded files * extract rootReducer into separate module for clarity * add reusable thunk function type * provide a thunk for important * provide a thunk to fetch experts * update state for Newest component * provide a thunk to fetch newest items * remove unneeded files * make type imports explicit to avoid import/no-cycle error * clear comments * fix type name * remove unneeded file * add type naming eslint rule, fix more types * fix type naming Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com> * Issue 61 fix expert popover (#62) * fix: ExpertDataCard * fix: ExpertPopover * fix: MainExpertsView style * fix: ExpertDataCard * fix: ExpertDataCard * Header branch (#58) * changes at app.tsx * header logic and material ua styles * change header logic and styles * change logic and styles * change styles and header logic * change logic * change logic and delete dropdown menu * delete component ListItems * add sonar scan plus jest code coverage (#65) * add sonar scan plus jest code coverage * fix env field in ci develop yml * trigger gh action * trigger action again * make separate action for sonar * change readme * fix readme * make a separate workflow for assemble * fix incorrect branches field in release.yml * fix indents in release yml * create a single script command on package json * integrate coverage script and clear unnecessary yml configs Co-authored-by: Anton Gluschuk <32397351+AntonGluschuk@users.noreply.github.com> Co-authored-by: Tetiana Polishchuk <57040275+tania833@users.noreply.github.com> Co-authored-by: Alexander <63422553+calster00@users.noreply.github.com> Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com> Co-authored-by: Yaroslav Zaychenko <66166679+DelFlumen@users.noreply.github.com> Co-authored-by: Darya Solomakha <56520654+darya42185@users.noreply.github.com> Co-authored-by: calster00 <63422553+calster00@users.noreply.github.com> Co-authored-by: Tania Polishchuk <tania.polischuk1998@gmail.com> Co-authored-by: Aleksandra <aleksandra@macbook2.local> Co-authored-by: Vitalii Kulinskyi <71768856+KarkabsisV@users.noreply.github.com> Co-authored-by: Solomaha Darya <solomaha_darya@ukr.net> Co-authored-by: Oleksandr Dubovenko <al.dubovenko@gmail.com> Co-authored-by: Anton Gluschuk <32397351+AntonGluschuk@users.noreply.github.com> Co-authored-by: Darya Solomakha <56520654+darya42185@users.noreply.github.com> Co-authored-by: DelFlumen <delflumen@ukr.net> Co-authored-by: Gtes <gates1993@gmail.com> Co-authored-by: FylViktoriia <viktoria.fyl1995@gmail.com> Co-authored-by: Tetiana Polishchuk <57040275+tania833@users.noreply.github.com> Co-authored-by: Yaroslav Zaychenko <66166679+DelFlumen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
timebox: 2d
The text was updated successfully, but these errors were encountered: