Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 🎨 [Design] Design of the block base layout #13

Closed
jrosseel opened this issue Jul 27, 2022 · 2 comments
Closed

🤖 🎨 [Design] Design of the block base layout #13

jrosseel opened this issue Jul 27, 2022 · 2 comments
Labels
1-pointer Simple class issue - 1 bounty points enhancement New feature or request good first issue Good for newcomers story-editor A feature related to the story editor
Milestone
Conversational Le...

Comments

@jrosseel
Copy link
Contributor

jrosseel commented Jul 27, 2022 •
edited
Loading

Overview

For consistency, we wish a base design template for each of the blocks. This base design is managed from the BlockComponent, from which all other blocks are loaded.

image

Technical analysis

  • Update all the changes in the convl-block component (features/convs-mgr/stories/blocks/library/main -> components/block)

  • Add blockTitle and blockIcon (type string) to the StoryBlock model
@jrosseel jrosseel added enhancement New feature or request good first issue Good for newcomers 1-pointer Simple class issue - 1 bounty points story-editor A feature related to the story editor labels Jul 27, 2022
@jrosseel jrosseel added this to the Conversational Learning MVP milestone Jul 27, 2022
This was referenced Jul 27, 2022
Closed
Closed
@IanKoech
Copy link

I will work on this issue

@pmutua pmutua mentioned this issue Aug 24, 2022
Closed
14 tasks
trevin-livele added a commit to trevin-livele/italanta-apps that referenced this issue Aug 29, 2022
@trevin-livele
{feature} added html structure and scss stylying to the block compone…
1ac40d2 
…nt to design the blocks with regards to issue italanta#13 for the block base layout
This was referenced Aug 29, 2022
Merged
Merged
trevin-livele added a commit to trevin-livele/italanta-apps that referenced this issue Sep 8, 2022
@trevin-livele
💄 (style) changed js plumb pointer connector from left to top (italan…
d5736ce 
…ta#13)
trevin-livele added a commit to trevin-livele/italanta-apps that referenced this issue Sep 8, 2022
@trevin-livele
♻️ (refactor) added blockTitle and blockIcon variables (italanta#13)
cdeb551
trevin-livele added a commit to trevin-livele/italanta-apps that referenced this issue Sep 12, 2022
@trevin-livele
💄 {refactor} corrected the order of imports in the block-library.mod…
773d40b 
…ule.ts regarding issue italanta#13
jrosseel added a commit that referenced this issue Sep 12, 2022
@jrosseel
Merge pull request #53 from trevin-livele/blockbase-layout#13
29a7453 
🎨 (feat)Application Design on the Block base layout issue #13
@jrosseel
Copy link
Contributor Author

Closed as resolved

@CarolGitonga CarolGitonga mentioned this issue Oct 14, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1-pointer Simple class issue - 1 bounty points enhancement New feature or request good first issue Good for newcomers story-editor A feature related to the story editor
Projects
Conversational Learning MVP - Jousting Board
Status: ⚔ In Joust
Milestone
Conversational Learning MVP
Development

No branches or pull requests
2 participants
@jrosseel @IanKoech