Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API pages are not indexed #256

Closed
alranel opened this issue Feb 2, 2019 · 3 comments · Fixed by #515
Closed

API pages are not indexed #256

alranel opened this issue Feb 2, 2019 · 3 comments · Fixed by #515
Assignees
@sebbalex
Labels
API API related issues bug
Projects
2.3.1 Sprint #2
Milestone
2.4.0

Comments

@alranel
Copy link
Member

alranel commented Feb 2, 2019

Searchyll does not index pages generated by data_page_generator.rb.

This repository contains a modified data_page_generator.rb (upstream here) that allows to add default data values to generated pages (we need lang and type).
@alranel alranel added bug new-version website new version labels Feb 2, 2019
@alranel
Copy link
Member Author

alranel commented Feb 2, 2019

Actually, they seem to be indexed (but not re-indexed automatically when using bundle exec jekyll serve. Check this.

@libremente libremente added the API API related issues label Aug 17, 2019
@libremente libremente added this to the 2.3.1 milestone Oct 2, 2019
@libremente
Copy link
Member

Right now it seems they are indexed twice (en and it) with the same title (in italian).

@sebbalex sebbalex removed the new-version website new version label Oct 15, 2019
@libremente libremente added this to To do in 2.3.1 via automation Jan 27, 2020
@sebbalex sebbalex added this to To do in Sprint #1 Feb 11, 2020
@sebbalex sebbalex removed this from To do in Sprint #1 Feb 18, 2020
@sebbalex sebbalex added this to To do in Sprint #2 via automation Feb 18, 2020
@sebbalex sebbalex modified the milestones: 2.3.1, 2.3.2 Feb 18, 2020
sebbalex added a commit that referenced this issue Feb 18, 2020
@sebbalex
Fix #256
192a1fb 
- APIs pages were set by default to lang `it`  even if they are not
@sebbalex
Copy link
Member

APIs pages were set by default to lang it even if they were published under another language folder, this caused duplicated entries in search engine when website is set to ITA lang and no results with ENG lang.
Search engine will filter results based on language set in website so they should be visibile in both languages even if they are published in only one of them.

@sebbalex sebbalex mentioned this issue Feb 18, 2020
Merged
@sebbalex sebbalex self-assigned this Feb 18, 2020
@sebbalex sebbalex moved this from To do to Review in progress in Sprint #2 Feb 18, 2020
Sprint #2 automation moved this from Review in progress to Done Feb 19, 2020
sebbalex added a commit that referenced this issue Feb 19, 2020
@sebbalex
Fix #256
2b9db64 
- APIs pages were set by default to lang `it`  even if they are not
LucaPrete pushed a commit that referenced this issue Jun 16, 2020
@sebbalex @LucaPrete
Fix #256
c5b0529 
- APIs pages were set by default to lang `it`  even if they are not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebbalex sebbalex

Labels
API API related issues bug
Projects
No open projects
2.3.1
  
To do
Sprint #2
  
Done
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Fix #256 - APIs page indexed twice italia/developers.italia.it
3 participants
@alranel @sebbalex @libremente