Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct classes for outline buttons #1458

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

smonolo
Copy link
Contributor

@smonolo smonolo commented Mar 24, 2024

Description

This PR introduces a series of fixes to outline buttons used around the website, which will occasionally have a strange behavior if btn-white class is not coupled with btn-outline-primary.

Checklist

  • I followed the indications in CONTRIBUTING.md
  • The documentation related to the proposed change has been updated accordingly (also comments in code).
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Ready for review! 馃殌

Fixes

Fixes #1457

@smonolo
Copy link
Contributor Author

smonolo commented Mar 24, 2024

Ready for review.

It might be also worth considering to create a shared component (include) with the buttons that exposes a prop to pass the Slack channel link, and import them everywhere is needed, so they will always look the same (right now they are all a copy paste).

@smonolo smonolo changed the title fix: use correct classes for outline buttons (#1457) fix: use correct classes for outline buttons Mar 24, 2024
@bfabio
Copy link
Member

bfabio commented Mar 25, 2024

Thanks @smonolo, looks like #1327 and #1093 didn't cover every button in the site.

A shared include could be an improvement. More structural solutions, ordered by increasing levels of effort are:

@bfabio bfabio merged commit fef4cd4 into italia:main Mar 25, 2024
2 of 3 checks passed
@smonolo smonolo deleted the fix/outline-buttons-styling branch March 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outline buttons are styled incorrectly
2 participants