Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News turns multi-language #321

Merged
merged 19 commits into from
May 7, 2019
Merged

News turns multi-language #321

merged 19 commits into from
May 7, 2019

Conversation

sebbalex
Copy link
Member

@sebbalex sebbalex commented May 2, 2019

  • Fixes Multi-language news #315
  • Pagination plugin switched to v2
  • Disabled tags for langs except italian due to limitation of jekyll-tagging
  • For posts (news) lang param has been replaced with locale, which is supported on paginate-v2

@libremente
Copy link
Member

@sebbalex could you please try to rebase this branch against new-version-master? Since this branch is 5 commits behind and there are 2 news translated in English which may be a real test case. You may need to switch lang to locale also on those new ones. Thank you!!

_config.yml Outdated Show resolved Hide resolved
_config.yml Outdated Show resolved Hide resolved
@sebbalex sebbalex requested a review from libremente May 2, 2019 21:17
@sebbalex
Copy link
Member Author

sebbalex commented May 2, 2019

Branch rebased with head of new-version-master, all conflicts solved

_pages/it/newst.md Outdated Show resolved Hide resolved
@sebbalex sebbalex requested a review from libremente May 3, 2019 14:11
@alranel alranel changed the base branch from new-version-master to master May 7, 2019 09:52
@alranel alranel merged commit bbdc252 into master May 7, 2019
@alranel alranel deleted the nvm-news-ml branch May 7, 2019 09:57
@alranel alranel mentioned this pull request May 7, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-language news
3 participants