Switches to the new docs_italia_theme as default #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds branch reference to install the new theme package - renames docs-italia-theme to docs_italia_theme - adds docs_italia_theme as default extension
xrmx
reviewed
Aug 7, 2018
| @@ -148,5 +148,6 @@ else: | |||
| # Add custom RTD extension | |||
| if 'extensions' in globals(): | |||
| extensions.append("readthedocs_ext.readthedocs") | |||
| extensions.append("docs_italia_theme") | |||
There was a problem hiding this comment.
Am not sure you need to add the theme as an extension, does this fix something?
There was a problem hiding this comment.
We need it because this theme is not only a collection of static templates and assets but include also many features added as extensions in its __init__.py. If we don't add the theme as an extension they don't work.
xrmx
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #51