Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce validation process #243

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

sebbalex
Copy link
Member

@sebbalex sebbalex commented Mar 16, 2022

  • validation process enforced
  • bump react-hook-forms
  • simple string arrayFields fix
  • touchFields instead of dirtyFields (this was unstable due to misuse of defaultValue in form fields)
  • label for arrayField fix
  • add CI workflow
  • add upload from file feature
  • fix network error notification during upload
  • language specific workflow must be reviewed
  • some label are missing
  • virtual file system is not supported in wasm, disable it (logo parsing)
  • fallback to DisableNetwork = true whether CORS is violated
  • ready to review 🎉

chore: rolling back to standard validation
chore: housekeeping for validator
fix: some fields were not using correct type
fix: multiple simpleStringArrays had serious problems
@sebbalex sebbalex requested a review from bfabio March 16, 2022 18:06
@vercel
Copy link

vercel bot commented Mar 16, 2022

@sebbalex is attempting to deploy a commit to the dip-trasformazione-digitale Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/publiccode-editor/33spEr7kW7aay9UJi3ue2hyNT7LZ
✅ Preview: https://publiccode-editor-git-fork-s-69104e-dip-trasformazione-digitale.vercel.app

languages were not successfully loaded after loading data from storage
default values were not succesfully set after a refresh
some safe check added
errors are more soft now
fix: network problem uploading using URL is now well communicated
fix: minor to all upload process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant