Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker compose for WSL2 compliancy #209

Merged
merged 7 commits into from
Mar 31, 2022
Merged

Fix docker compose for WSL2 compliancy #209

merged 7 commits into from
Mar 31, 2022

Conversation

danielegiallonardo
Copy link
Contributor

In a Windows+WSL2 environment, external volumes don't work.
In this PR a proposed solution with classic volumes

peppelinux and others added 4 commits March 31, 2022 11:14
Several fixes and improvements, OAS3 and Docker compose
External volumes don't work under Windows+WSL2
@peppelinux
Copy link
Member

Thank you @danielegiallonardo

we should have some little changes on your very good proposal, these are:

  1. Please merge the dev branch to get the last commits on the README
  2. Please add an instruction to copy the example folder to another example_new or whatever, otherwise the changes we do on the dumps will affect the git tree.

Did you get it?
We should copy the example folder to another one to be ignored in .gitignore

once we have this I think that I'll abandon the external storage (+ thankfulness to you)

@danielegiallonardo
Copy link
Contributor Author

danielegiallonardo commented Mar 31, 2022

I've merged the changes from upstream.
About the git tree, in order to execute the entire federation with an external RP, 4 files have been changed: the compose file (to include the section for the external RP) and the three dump files (to replace 127.0.0.1 with the hostnames).
I have a couple of suggestions about that:

  • you could always use the hostnames (accordingly with the services included in the compose file) into your dumps, so it won't be necessary to modify them to launch the compose. This allows us just to make a "git pull" and a "docker-compose --build" on the django repo in order to have the new changes from the origin and have the data migrations run in a backward compatible way on the existing data, otherwise it would be necessary to re-copy the example folders each time.
  • we could agree on a "modified compose" name to put in gitignore (to include the external RP section)

@peppelinux peppelinux merged commit d19128b into italia:dev Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants