feat: added method to show correct RP organization_name in OP pages #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
requested changes
Feb 7, 2024
| ) | ||
|
|
||
| def get_client_organisation_name(self, tc): |
Comment on lines
400
to
408
| fed_metadata = tc.metadata.get("federation_entity", {}) | ||
| name = fed_metadata.get("organization_name", "") | ||
| if not name: | ||
| op_metadata = tc.metadata.get("openid_relying_party", {}) | ||
| name = op_metadata.get("organization_name", "") | ||
| if not name: | ||
| name = op_metadata.get("client_name", "") | ||
| if not name: | ||
| name = op_metadata.get("client_id", "") |
There was a problem hiding this comment.
Suggested change
| fed_metadata = tc.metadata.get("federation_entity", {}) | |
| name = fed_metadata.get("organization_name", "") | |
| if not name: | |
| op_metadata = tc.metadata.get("openid_relying_party", {}) | |
| name = op_metadata.get("organization_name", "") | |
| if not name: | |
| name = op_metadata.get("client_name", "") | |
| if not name: | |
| name = op_metadata.get("client_id", "") | |
| rp_metadata = ( | |
| tc.metadata.get( | |
| "federation_entity", {} | |
| ).get("organization_name", "") or | |
| tc.metadata.get( | |
| "openid_relying_party", {} | |
| ) | |
| ) | |
| if rp_metadata: | |
| name = ( | |
| rp_metadata.get("organization_name", "") or | |
| rp_metadata.get("client_name", "") or | |
| rp_metadata.get("client_id", "") | |
| ) |
There was a problem hiding this comment.
accepted change, corrected a typo:
rp_metadata = (
tc.metadata.get(
"federation_entity", {}
) .get("organization_name", "")
peppelinux
reviewed
Feb 7, 2024
peppelinux
reviewed
Feb 7, 2024
peppelinux
reviewed
Feb 7, 2024
peppelinux
reviewed
Feb 7, 2024
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Updated cryptography to 42.0.2 for rsa method