Skip to content

Commit

Permalink
Use present? method from active_support/core_ext/object
Browse files Browse the repository at this point in the history
  • Loading branch information
davidlibrera committed Jul 2, 2018
1 parent cd5675f commit a44e74a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

require "simplecov"
require "coveralls"
require "active_support/core_ext/object"

SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
[
Expand Down
10 changes: 5 additions & 5 deletions spec/spid/authn_request_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
let(:attributes) { authn_request_node.attributes }

it "exists" do
expect(authn_request_node).not_to be_nil
expect(authn_request_node).to be_present
end

it "contains attribute ID" do
Expand Down Expand Up @@ -84,7 +84,7 @@
end

it "exists" do
expect(attribute).not_to be_nil
expect(attribute).to be_present
end
end
end
Expand Down Expand Up @@ -112,7 +112,7 @@
let(:attributes) { issuer_node.attributes }

it "exists" do
expect(issuer_node).not_to be_nil
expect(issuer_node).to be_present
end

it "contains sp_entity_id" do
Expand Down Expand Up @@ -141,7 +141,7 @@
let(:attributes) { name_id_policy_node.attributes }

it "exists" do
expect(name_id_policy_node).not_to be_nil
expect(name_id_policy_node).to be_present
end

it "contains attribute Format" do
Expand Down Expand Up @@ -171,7 +171,7 @@
let(:attributes) { requested_authn_context.attributes }

it "exists" do
expect(requested_authn_context).not_to be_nil
expect(requested_authn_context).to be_present
end

describe "attribute Comparison" do
Expand Down
2 changes: 1 addition & 1 deletion spec/spid/metadata_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
end

it "exists" do
expect(entity_descriptor_node).not_to be_nil
expect(entity_descriptor_node).to be_present
end
end
end
Expand Down
1 change: 1 addition & 0 deletions spid.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Gem::Specification.new do |spec|

spec.add_runtime_dependency "ruby-saml", "~> 1.8", ">= 1.8.0"

spec.add_development_dependency "activesupport", ">= 3.0.0"
spec.add_development_dependency "bundler", "~> 1.16"
spec.add_development_dependency "bundler-audit", "~> 0"
spec.add_development_dependency "coveralls", "~> 0"
Expand Down

0 comments on commit a44e74a

Please sign in to comment.