Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero test run in Travis CI master build #25

Closed
gvespucci opened this issue Feb 6, 2022 · 3 comments · Fixed by #28
Closed

Zero test run in Travis CI master build #25

gvespucci opened this issue Feb 6, 2022 · 3 comments · Fixed by #28

Comments

@gvespucci
Copy link
Contributor

gvespucci commented Feb 6, 2022 •
edited
Loading

Dando una occhiata al log della ultima build di master di Travis CI, sembra come se non esegua in realtà nessuna test del modulo spid-spring-integration.

-------------------------------------------------------

 T E S T S

-------------------------------------------------------

Running it.italia.developers.spid.integration.service.test.SPIDIntegrationServiceTest

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec

Running it.italia.developers.spid.integration.util.SPIDIntegrationUtilTest

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

IMHO credo manchi la dipendenza esplicita dal maven-surefire-plugin nel main pom.xml.

Sono io che mi sto perdendo qualcosa?
Grazie
@peppelinux
Copy link
Member

Ciao @gvespucci
se possibile consiglierei vivamente di abbandonare travis e migrare a gh actions

@gvespucci
Copy link
Contributor Author

gvespucci commented Feb 6, 2022 •
edited
Loading

Ciao @peppelinux, nulla in contrario. In realtà questa cosa dei 0 test credo abbia rivelato un problema di configurazione di Maven. Ho aggiunto la configurazione di Surefire, come dicevo su, e i test vengono invocati durante la build.
Ma ora abbiamo 2 fallimenti dovute a 2 NPE. 🤔
Siccome ho appena conosciuto il progetto, non so bene chi siano i maintainer e di come continuare la discussione. Cosa mi consigli? Grazie

@peppelinux
Copy link
Member

Sentiti libero di fare PR, io vedrò la CI funzionare e lo uniamo

raggiungici su slack developers italia, sul canale spid-spring, se vuoi conoscere i developers che nel tempo hanno contribuito

gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 12, 2022
@gvespucci
italia#25 Add Surefire configuration to make the tests run
2a00079
gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 12, 2022
@gvespucci
italia#25 refactor: Rename service method, rationalize exceptions, us…
ff580a1 
…e Get/Post Spring annotations
gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 13, 2022
@gvespucci
italia#25 refactor: Expand * import; realign code
6126164
gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 13, 2022
@gvespucci
italia#25 refactor: Inline return variables; organize similar excepti…
1fdcc94 
…on blocks
gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 13, 2022
@gvespucci
italia#25 refactor: Inline return variables; organize similar excepti…
daeb900 
…on blocks
gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 13, 2022
@gvespucci
italia#25 refactor: Inline return variables; make tests run again
ef15394
gvespucci added a commit to gvespucci/spid-spring that referenced this issue Feb 13, 2022
@gvespucci
italia#25 feat: Add .gitattributes to normalize line endings.
5b9af2d 
    See: https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/ and
    https://rehansaeed.com/gitattributes-best-practices/#line-endings
@gvespucci gvespucci mentioned this issue Feb 13, 2022
Merged
marque88 pushed a commit that referenced this issue Feb 13, 2022
@gvespucci
Fix / Make unit tests run (#28)
e4becb2 
* #25 Add Surefire configuration to make the tests run

* #25 refactor: Rename service method, rationalize exceptions, use Get/Post Spring annotations

* #25 refactor: Expand * import; realign code

* #25 refactor: Inline return variables; organize similar exception blocks

* #25 refactor: Inline return variables; organize similar exception blocks

* #25 refactor: Inline return variables; make tests run again

* #25 feat: Add .gitattributes to normalize line endings.
    See: https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/ and
    https://rehansaeed.com/gitattributes-best-practices/#line-endings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix / Make unit tests run gvespucci/spid-spring
2 participants
@gvespucci @peppelinux