Fix a bug that displays inappropriate diff in file deletion

[takus]

It seems that template resource's :delete action doesn't work as what I suppose. It always displays contents of its source. I think itamae should suppress diff in :delete action like below.

before

itamae local bootstrap.rb
 INFO : Starting Itamae...
 INFO : Recipe: /opt/itamae/bootstrap.rb
 INFO :   Recipe: /opt/itamae/cookbooks/java/tomcat.rb
 INFO :     template[/usr/share/tomcat7/newrelic/newrelic.yml] exist will change from 'true' to 'false'
 INFO :     diff:
 INFO :     --- /usr/share/tomcat7/newrelic/newrelic.yml        2016-02-17 11:12:18.541089617 +0000
 INFO :     +++ /tmp/itamae_tmp/1455707545.4180827      2016-02-17 11:12:25.413097913 +0000
 INFO :     @@ -0,0 +1,277 @@
 INFO :     +# This file configures the New Relic Agent.  New Relic monitors
 INFO :     +# Java applications with deep visibility and low overhead.  For more details and additional
 INFO :     +# configuration options visit https://docs.newrelic.com/docs/java/java-agent-configuration.
....

after

itamae local bootstrap.rb
 INFO : Starting Itamae...
 INFO : Recipe: /opt/itamae/bootstrap.rb
 INFO :   Recipe: /opt/itamae/cookbooks/java/tomcat.rb
 INFO :     template[/usr/share/tomcat7/newrelic/newrelic.yml] exist will change from 'true' to 'false'
...

Although this code passes tests, I'm not sure this is a good way to suppress inappropriate diff. Plz give me feedback if you guys have good ideas.

[ryotarai]

Thank you for your pull request.

It always displays contents of its source. I think itamae should suppress diff in :delete action like below

I agree that.

I'm not sure this is a good way to suppress inappropriate diff. Plz give me feedback if you guys have good ideas.

It is better to modify show_differences method in File class, because delete action of template resource is actually delete action of file resource.
How about fixing

itamae/lib/itamae/resource/file.rb

Line 53 in 216d1e4

if @temppath

like the following?

-        if @temppath
+        if @temppath && @current_action != :delete
           compare_file
         end

[takus]

Thanks for the comment. Your suggestion seems better. I've fixed it.

[ryotarai]

Sorry for late response. I'm about to merge this.
Thank you for your contribution.

[takus]

Thanks 🍣

[ryotarai]

released v1.9.4