-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh config parsing: expand ~ in IdentityAgent path #12939
Conversation
ssh/src/main/java/ch/cyberduck/core/sftp/openssh/config/transport/OpenSshConfig.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type of identityAgent
must be changed accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review usages of getIdentityAgent
.
Is this OK or would you rather move the
|
ssh/src/main/java/ch/cyberduck/core/sftp/openssh/OpenSSHIdentityAgentConfigurator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please sqash the commits to a single commit using rebase -i master
.
Currently if a user has an option in their ssh config file like this:
IdentityAgent ~/.1password/agent.sock
then cyberduck can't open the socket because the ~ in the path isn't expanded, it's treated as a literal ~
(But
IdentityAgent /Users/myname/.1password/agent.sock
works correctly)This PR applies the same logic to
IdentityAgent
as is already used forIdentityFile
, so paths with ~ work correctly.Thanks