Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local protocol open with #14334

Merged
merged 2 commits into from Mar 9, 2023
Merged

Fix local protocol open with #14334

merged 2 commits into from Mar 9, 2023

Conversation

AliveDevil
Copy link
Contributor

Fixes #14332

@AliveDevil
Add failing test
9ac3792 
Local-protocol may come with unsanitized paths (create C:\C:\), which will fail
@AliveDevil
Calling into base() won't call class sanitization rules
53f59eb
@AliveDevil AliveDevil added this to the 8.5.7 milestone Mar 9, 2023
@AliveDevil AliveDevil self-assigned this Mar 9, 2023
@AliveDevil AliveDevil added the interface User Interface label Mar 9, 2023
@AliveDevil AliveDevil marked this pull request as ready for review March 9, 2023 11:51
@AliveDevil AliveDevil requested a review from a team as a code owner March 9, 2023 11:51
@dkocher dkocher merged commit c52332e into master Mar 9, 2023
4 checks passed
@dkocher dkocher deleted the bugfix/GH-14332 branch March 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkocher dkocher dkocher approved these changes

Assignees

@AliveDevil AliveDevil

Labels
interface User Interface
Projects
None yet
Milestone
8.5.7
Development

Successfully merging this pull request may close these issues.

InvalidPathException when using "Open With" on Windows
2 participants
@AliveDevil @dkocher