Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bonjour optional & visible in apps & programs #14630

Merged
merged 3 commits into from May 10, 2023
Merged

Conversation

AliveDevil
Copy link
Contributor

  • Add checkbox in Options-panel
  • Make Bonjour not installed through command line Setup.exe InstallBonjour=0
  • Auto-Update doesn't install Bonjour after every install

This setting cannot be persisted across installations, as Wix doesn't support this.

Resolves #13416

@AliveDevil AliveDevil added enhancement installer Windows Installer labels May 8, 2023
@AliveDevil AliveDevil self-assigned this May 8, 2023
@AliveDevil AliveDevil requested a review from a team as a code owner May 8, 2023 10:42
@AliveDevil
Copy link
Contributor Author

Do we want to install Bonjour in the Chocolatey-installer?

@AliveDevil

This comment was marked as outdated.

@dkocher dkocher added this to the 8.6.0 milestone May 8, 2023
@dkocher dkocher merged commit 5b41b4c into master May 10, 2023
5 checks passed
@dkocher dkocher deleted the bugfix/GH-13416 branch May 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement installer Windows Installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bonjour installation is not optional, can't be removed via normal means
2 participants