Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test authentication #33

Merged
merged 4 commits into from May 6, 2020
Merged

test authentication #33

merged 4 commits into from May 6, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented May 6, 2020

Add authentication test

prevents regression (#31)

- continues #32
@casperdcl casperdcl self-assigned this May 6, 2020
@casperdcl casperdcl requested a review from shcheklein May 6, 2020 19:05
@casperdcl casperdcl marked this pull request as ready for review May 6, 2020 19:07
@casperdcl casperdcl added the bug Something isn't working label May 6, 2020
@casperdcl
Copy link
Contributor Author

casperdcl commented May 6, 2020

On a related note... the tests are not designed to run concurrently.

  • one job from the PR build failed at the same time as a job from the branch build because they interfered with each other
  • tests are slow as they are not run in parallel

Really should fix this (e.g. timestamp filenames)

@shcheklein
Copy link
Member

the only minor ask - let's name the test with some meaningful name and put some comment?

other tests are generic ... this one tests a pretty specific behavior.

@shcheklein
Copy link
Member

the tests are not designed to run concurrently.

agreed! let's create a ticket for this in this repo. Not sure we have capacity to do this now unfortunately, but will try to handle somewhere down the road. It's good that we have tests running at all.. Initial pydrive does not have them at all 🤷‍♂️

pydrive2/test/test_file.py Outdated Show resolved Hide resolved
@casperdcl casperdcl mentioned this pull request May 6, 2020
@shcheklein shcheklein merged commit f8128c8 into master May 6, 2020
@casperdcl casperdcl deleted the auth-test branch May 7, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants