Skip to content

files: fix auth for GetContentFile #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

files: fix auth for GetContentFile #32

merged 1 commit into from
May 6, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented May 6, 2020 •
edited
Loading

Odd that there are no tests which picked up on this.

@casperdcl casperdcl requested a review from shcheklein May 6, 2020 15:53
@casperdcl casperdcl self-assigned this May 6, 2020
@casperdcl casperdcl added the bug Something isn't working label May 6, 2020
@shcheklein shcheklein merged commit 269c92b into master May 6, 2020
@casperdcl
Copy link
Contributor Author

actually they should have picked up on this:

PyDrive2/pydrive2/test/test_file.py

Lines 143 to 144 in d9eca5b

file2 = drive.CreateFile({"id": file1["id"]}) # Download file from id.
pydrive_retry(lambda: file2.GetContentFile(self.first_file + "2"))

@casperdcl
Copy link
Contributor Author

no - re-used drive object already authenticated. New test required to prevent regression.

@casperdcl casperdcl deleted the auth-fix branch May 6, 2020 16:24
casperdcl added a commit that referenced this pull request May 6, 2020
@casperdcl
test authentication
3b2c42a 
prevents regression (#31)

- continues #32
@casperdcl casperdcl mentioned this pull request May 6, 2020
Merged
2 tasks
shcheklein pushed a commit that referenced this pull request May 6, 2020
@casperdcl @shcheklein
test authentication
378f115 
prevents regression (#31)

- continues #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees

@casperdcl casperdcl

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

file.GetContentFile(...) throws AttributeError as of version 1.4.11

2 participants

@casperdcl @shcheklein