Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Node.js version on GitHub Actions test job #1382

Merged
merged 1 commit into from Jun 3, 2023
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jun 2, 2023

GitHub Actions' default Node.js version was upgraded (actions/runner-images#7002) to version 18 recently and emscripten-core/emscripten#16913 was breaking our tests.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 2, 2023 23:56 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team June 2, 2023 23:56
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 2, 2023
@0x2b3bfa0 0x2b3bfa0 added the testing Unit tests & debugging label Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 3, 2023
@0x2b3bfa0
Copy link
Member Author

Force-merging because we need this on the main branch in order to fix tests. 😅

@0x2b3bfa0 0x2b3bfa0 merged commit 0868799 into master Jun 3, 2023
15 of 16 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the fix-tests branch June 3, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Unit tests & debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant