review all workflows #498
Merged
review all workflows #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
casperdcl
commented
May 5, 2021
casperdcl
commented
- fix bot tests (follow up to Refactor GitHub Actions release workflow and Dockerfile #494)
- fix security issues (global token use)
- misc tidy
- fix security issues - misc tidy
- follow up to #494
casperdcl
commented
May 5, 2021
Comment on lines
+27
to
+31
| env: | ||
| CML_VERSION: 0 | ||
| DVC_VERSION: 2 | ||
| PYTHON_VERSION: 3.8 | ||
| BASE_IMAGE: 'ubuntu:20.04' |
There was a problem hiding this comment.
- Before, it was building both py2 & py3, but pushing just py2.
+ Now it's only building & pushing py3.Hope that's ok
There was a problem hiding this comment.
Taking into account that Py3 is the extended image is OK. The build was to ensure that everything could be built
|
Argh! I have allergy to trailing backslashes! 😄 Anyhow, at least it doesn't get automatically wrapped by the linter. |
Co-authored-by: Casper da Costa-Luis <work@cdcl.ml>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.