Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GitHub Actions release workflow and Dockerfile #494

Merged
merged 6 commits into from
May 5, 2021

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented May 1, 2021

This pull request contains the code I wrote when posting my last comments on #217; please refer to the issue for a thorough explanation of the suggested changes.

@0x2b3bfa0 0x2b3bfa0 linked an issue May 1, 2021 that may be closed by this pull request
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented May 1, 2021

In order to consolidate all the images under a single repository, GPU-specific images will be part of the standard CML repository and just contain the -gpu suffix in tag names.

@0x2b3bfa0
Copy link
Member Author

Once we review and merge this pull request, repositories listed in #383 and some of the ones in #217 can be readily deleted.

@0x2b3bfa0 0x2b3bfa0 linked an issue May 4, 2021 that may be closed by this pull request
@casperdcl casperdcl changed the base branch from master to devel May 5, 2021 14:14
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@casperdcl casperdcl added cml-image Subcommand technical-debt Refactoring, linting & tidying labels May 5, 2021
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl May 5, 2021 15:56
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor naming

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Co-authored-by: Casper da Costa-Luis <work@cdcl.ml>
@casperdcl casperdcl merged commit b1f2cc3 into devel May 5, 2021
@casperdcl casperdcl deleted the better-tagging branch May 5, 2021 17:03
@casperdcl casperdcl mentioned this pull request May 5, 2021
2 tasks
casperdcl added a commit that referenced this pull request May 5, 2021
@casperdcl casperdcl mentioned this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-image Subcommand technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating python3 version on dvcorg/cml-py3:runner CML docker version tagging
2 participants