reflink: set mode to 0o666 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Dec 6, 2023
| @@ -91,7 +91,7 @@ def reflink(src, dst): | |||
| src_fd = os.open(src, os.O_RDONLY) | |||
|
|
|||
| try: | |||
| dst_fd = os.open(dst, os.O_WRONLY | os.O_CREAT | os.O_TRUNC) | |||
| dst_fd = os.open(dst, os.O_WRONLY | os.O_CREAT | os.O_TRUNC, 0o666) | |||
There was a problem hiding this comment.
Suggested change
| dst_fd = os.open(dst, os.O_WRONLY | os.O_CREAT | os.O_TRUNC, 0o666) | |
| dst_fd = os.open(dst, os.O_WRONLY | os.O_CREAT | os.O_TRUNC, 0o666 & ~umask) |
this would be the proper way, strictly speaking
There was a problem hiding this comment.
Isn't os.open doing that? Let me take a look.
There was a problem hiding this comment.
Open the file path and set various flags according to flags and possibly its mode according to mode. When computing mode, the current umask value is first masked out
efiop
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that at least executable bit does not get set. Still leaves a security related question, but that issue was already there before.