Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: azure: fix cloud config docs #2485

Closed
5 tasks done
shcheklein opened this issue May 18, 2021 · 5 comments
Closed
5 tasks done

ref: azure: fix cloud config docs #2485

shcheklein opened this issue May 18, 2021 · 5 comments
Assignees
@isidentical
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference
Projects
DVC 27 Jul - 10 Aug DVC 10 Aug - 24 Aug 2021

Comments

@shcheklein
Copy link
Member

shcheklein commented May 18, 2021 •
edited by isidentical

Specifically dvc remote modify:

  • Link all env var does not cover all vars (remove for now)
  • We need to list actually available vars - e.g. I see AZURE_CONFIG_DIR - do we mention it?
  • AZURE_STORAGE_CONNECTION_STRING, AZURE_STORAGE_CONTAINER_NAME - what else?
  • Small style bug with code block
  • dvc end: check unable to connect to account for Must provide either a connection_string or account_name with credentials!! message - it has a few errors in it.

cc @isidentical
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) dvc-update labels May 18, 2021
shcheklein added a commit that referenced this issue May 18, 2021
@shcheklein
ref: remote modify: update azure info as per #2485
bc3a78b
@isidentical
Copy link
Contributor

pre requisite: iterative/dvc/pull/5833

@jorgeorpinel jorgeorpinel mentioned this issue May 18, 2021
Merged
@isidentical isidentical added this to To do in DVC 27 Jul - 10 Aug via automation Jul 27, 2021
@isidentical
Copy link
Contributor

dvc end: check unable to connect to account for Must provide either a connection_string or account_name with credentials!! message - it has a few errors in it.

This message have been replaced with
https://github.com/iterative/dvc/blob/fd76e0991f6dd47e554b874c2efb8c280dee96c0/dvc/fs/azure.py#L93-L99

@isidentical isidentical mentioned this issue Aug 10, 2021
Merged
@isidentical isidentical moved this from To do to Review in progress in DVC 27 Jul - 10 Aug Aug 10, 2021
@skshetry skshetry added this to To do in DVC 10 Aug - 24 Aug 2021 via automation Aug 10, 2021
@skshetry skshetry moved this from Review in progress to Done in DVC 27 Jul - 10 Aug Aug 10, 2021
@isidentical isidentical moved this from To do to Review in progress in DVC 10 Aug - 24 Aug 2021 Aug 10, 2021
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Aug 11, 2021 •
edited

Is there anything else left in this issue? I see one pending check box in the description. Thanks

@isidentical
Copy link
Contributor

@jorgeorpinel Pending checkbox should be resolved by this: #2703

@jorgeorpinel
Copy link
Contributor

Just noticed that, will review. Please link that PR so it closes this issue. Thanks

DVC 10 Aug - 24 Aug 2021 automation moved this from Review in progress to Done Aug 24, 2021
@iesahin iesahin added the C: ref Content of /doc/*-reference label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isidentical isidentical

Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference
Projects
No open projects
DVC 10 Aug - 24 Aug 2021
  
Done
DVC 27 Jul - 10 Aug
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iesahin @jorgeorpinel @shcheklein @isidentical