azure: better error messages / allow_anonymous_login option #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
isidentical
force-pushed
the
explicit-anon
branch
from
7e3ad5d
to
4f05aa5
Compare
isidentical
changed the title
dberenbaum
approved these changes
May 18, 2021
efiop
reviewed
May 19, 2021
Comment on lines
+121
to
+125
| "Authentication to Azure Blob Storage requires either " | ||
| "account_name or connection_string.\nLearn more about " | ||
| "configuration settings at " | ||
| + format_link("https://man.dvc.org/remote/modify") |
There was a problem hiding this comment.
I'm not 100% sure I get this change (see Q in iterative/dvc.org#2489 (review)) but maybe:
Suggested change
| "Authentication to Azure Blob Storage requires either " | |
| "account_name or connection_string.\nLearn more about " | |
| "configuration settings at " | |
| + format_link("https://man.dvc.org/remote/modify") | |
| "Authentication to Azure Blob Storage requires setting either " | |
| "account_name or connection_string.\nLearn more about " | |
| "remote storage settings at " | |
| + format_link("https://man.dvc.org/remote/modify") |
Some quick explanation of the change in the PR desc. would be great. Or link to a specific comment in #5797. Cc @casperdcl
isidentical
force-pushed
the
explicit-anon
branch
from
210d9a0
to
46055a8
Compare
isidentical
force-pushed
the
explicit-anon
branch
from
46055a8
to
89d50bc
Compare
efiop
approved these changes
May 31, 2021
Suor
reviewed
Jun 17, 2021
| if ( | ||
| login_info["account_name"] | ||
| and not any_secondary | ||
| and not config.get("allow_anonymous_login") |
There was a problem hiding this comment.
I don't see this option in config schema or anywhere in DVC outside of tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. (azure: update docs for explicit anonymous login dvc.org#2489)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Part of #5797. Implements the
allow_anonymous_optionand support for anonymous logins.