Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add static files to the static repo? #4837

Closed
tapadipti opened this issue Sep 6, 2023 · 3 comments
Closed

Should we add static files to the static repo? #4837

tapadipti opened this issue Sep 6, 2023 · 3 comments
Labels
p1-important Active priorities to deal within next sprints type: discussion Requires active participation to reach a conclusion.

Comments

@tapadipti
Copy link
Contributor

I've been uploading most of the static files (images/gifs) to the static repo. But we're not doing this consistently (even I don't do it always, coz it's not a regular practice).

What should we do going forward - add the static files to the static repo or to this (dvc.org) repo? Let's decide on one, or on some rule (eg, files larger than <> size should be uploaded to the static repo).

@tapadipti tapadipti added type: discussion Requires active participation to reach a conclusion. p1-important Active priorities to deal within next sprints labels Sep 6, 2023
@dberenbaum
Copy link
Contributor

@tapadipti Can we close or at least lower the priority? Doesn't seem like there is a strong reason to do one or the other AFAICT.

@tapadipti
Copy link
Contributor Author

I'm closing this. We didn't get to discussing this in 4 months, and I guess we won't in a while. So, we'll continue as-is for now.

@tapadipti tapadipti closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@shcheklein
Copy link
Member

@tapadipti please use static repo for gifs and large images. It will be hard to revert and cleanup this repo otherwise. Eventually we should use DVC in dvc.org as well. Like we do for iterative.ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-important Active priorities to deal within next sprints type: discussion Requires active participation to reach a conclusion.
Projects
None yet
Development

No branches or pull requests

3 participants