Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model registry docs consolidation #5133

Merged
merged 14 commits into from
Feb 26, 2024
Merged

Model registry docs consolidation #5133

merged 14 commits into from
Feb 26, 2024

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Feb 16, 2024

This is an attempt to rework the docs in response to feedback that it's confusing and makes it hard to get started with our tools. I started with model registry because it's more limited than trying to redo experiments or data management.

The goal is to address a few different issues:

The PR drops the two model registry overview pages in the Studio docs:

The content was integrated into other pages (often it was already in other pages). The idea is to have high-level docs in one place and product-specific docs only for detailed guides/reference.

@shcheklein shcheklein temporarily deployed to dvc-org-start-add-model-crakny February 16, 2024 19:50 Inactive
Copy link
Contributor

github-actions bot commented Feb 16, 2024

Link Check Report

There were no links to check!

@shcheklein shcheklein temporarily deployed to dvc-org-start-add-model-crakny February 16, 2024 20:13 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-start-add-model-crakny February 16, 2024 20:54 Inactive
Comment on lines 1 to 4
---
title: 'Get Started: Add a model'
description: 'Start tracking model artifacts with DVC.'
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new page here to:

  1. Consolidate info from https://dvc.org/doc/start/model-management/model-registry and https://dvc.org/doc/studio/model-registry
  2. Make the first page less intimidating/quicker by focusing only on what's needed to add a model

@shcheklein shcheklein temporarily deployed to dvc-org-start-add-model-crakny February 16, 2024 21:16 Inactive
@@ -9,23 +9,31 @@ description:

# Get Started: Model Management

https://www.youtube.com/watch?v=T7MBFpnSr9Q
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include Jelle's recent video for people who don't want to read docs

These are captured in our [example-get-started-experiments] repo. You can [fork
it][example-get-started-experiments-fork] to follow along, or you can take a
look at our
[public model registry](https://studio.iterative.ai/team/Iterative/models) (read
Copy link
Contributor Author

@dberenbaum dberenbaum Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to public model registry for those who just want to see what it looks like (taken from https://dvc.org/doc/studio/user-guide/model-registry)

@@ -7,149 +7,48 @@ description:

# Get Started: Model Registry

Just as we use experiment tracking to manage model development, it is a good
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this info to its own page

Comment on lines -130 to -138
manage our model registry. DVC Studio enables you to see models across all
projects, manage their lifecycle, and download them with only a token. You can
find out more about it [here](/doc/studio).

From the Models tab in DVC Studio we will have an overview of all models, latest
model versions as well stages each of the model versions is assigned to. We can
get more details for each model by clicking on the model name.

You can check out our
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tries to cut down intro here to get to showing the Studio UI ASAP

[example model](https://studio.iterative.ai/team/Iterative/models/b3P4bcYIrGYdzyjqzsf9Xw==/pool-segmentation/v1.0.0)
in DVC Studio to see what it will look like once we finish all the steps in this
guide.

Now that we have added a model, you should see something like the following
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the changes on this page are just moving existing content around to fit the new structure

@shcheklein shcheklein temporarily deployed to dvc-org-start-add-model-crakny February 16, 2024 21:22 Inactive
@shcheklein shcheklein had a problem deploying to dvc-org-start-add-model-crakny February 16, 2024 21:25 Failure
@dberenbaum dberenbaum marked this pull request as ready for review February 16, 2024 21:26
@dberenbaum dberenbaum requested a review from a team as a code owner February 16, 2024 21:26
@dberenbaum dberenbaum requested review from tibor-mach and tapadipti and removed request for a team February 16, 2024 21:26
@dberenbaum
Copy link
Contributor Author

@yathomasi Heroku is throwing an error:

 !     Compiled slug size: 1.4G is too large (max is 500M).
 !     See: http://devcenter.heroku.com/articles/slug-size
 !     Push failed

Any ideas how to fix it? Can adding static files to the static repo (see #4837) help?

@yathomasi yathomasi temporarily deployed to dvc-org-start-add-model-crakny February 21, 2024 06:06 Inactive
@yathomasi
Copy link
Contributor

yathomasi commented Feb 21, 2024

Any ideas how to fix it?

I see it didn't run the gatsby build command at all so ended with huge size of node modules and cache.

I have retriggered the build manually and hope it will be fixed. ICYMI: there is a Manual deploy section in Deploy tab

Screenshot 2024-02-21 at 11 54 09

UPD: Deployed successfully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dberenbaum If we remove this page, I think we should also remove the Experiments page which is at the same level. But the reason we recently added these pages is to make it easier for Studio users to find the core features of Studio. I think that we should work to consolidate the Get Started -> Model Management docs with the Model Registry user guide so that there's one source of the model registry guide. And then this page can serve as just a pointer to the guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! That's exactly what this PR does. See the changes to the redirects, which redirects this page to the guide. So it will still show up in the sidebar for now, since it was too much to also get rid of the Experiments page at the same time, but clicking on it will go straight to the guide.

Re: consolidation, the idea with this PR is that model registry docs are in 3 places (and link between each other where appropriate):

  1. Use case - overview, why a MR, why ours
  2. Get started - quick intro to learn how to use MR
  3. Studio guide - in-depth info

Copy link
Contributor

@tapadipti tapadipti Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see the issue. You added a redirect to a page that you deleted (/doc/studio/user-guide/model-registry). So that link broke when I was running this locally and I thought you meant to delete that link altogether. With your changes, the guide now starts at /doc/studio/user-guide/model-registry/add-a-model. Not sure if that is the right page for this link. May be we should link it to /doc/use-cases/model-registry? But even that is not the right page, coz this is supposed to be a quick start guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected the link here (redirected to the add a model page).

Copy link
Contributor Author

@dberenbaum dberenbaum Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tapa!

May be we should link it to /doc/use-cases/model-registry? But even that is not the right page, coz this is supposed to be a quick start guide.

We could link to the get started doc, but I also think ultimately the goal is to drop /doc/studio/model-registry once we can also drop /doc/studio/experiments, so not a major concern to me.

Copy link
Contributor

@tibor-mach tibor-mach Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use case - overview, why a MR, why ours
  • Get started - quick intro to learn how to use MR
  • Studio guide - in-depth info

I still need to have a proper look at the changes but I really like this structure, in fact this is how I think all of the docs should be organised (and a fourth part which is just the API documentation). This is what Django uses, there was a great talk about this structure from one of its founders (but I cannot find it now).

And the Get Started stuff should be extremely prominent, right at the first page of the docs, the first thing you see (it also goes back to what we talked about on Thursday)

Personally, I would like to see Studio included in the docs more prominently, kind of the way I tried to do it with the Get Started guide on MR. Studio should be a first class citizen I think. You should still be able to see how to do the same stuff with FOSS but Studio should be the first one we show. And then specific Studio guides would be there only for the stuff not relevant otherwise (like setting up Studio, managing user permissions etc).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I would try to make this structure as explicit as possible. For example with Studio it really is not all that clear. The Get Started guide are really not in Studio documentation itself, but in the DVC documentation.

The Use case part is also detached.

Maybe even removing a specific subpage for Studio and integrating it into the rest (and dividing that explicitly into these four parts) might be the best. This way it is also easier to maintain it and avoid duplicates between Studio docs and the rest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I open the documentation of Djanjgo, the first thing I see are links to the get started guides - the tutorial for complete beginners and then more advanced tutorials. The second thing you see are links to where to ask questions about the framework. And then some info about how the docs are structured so everyone can figure that out quickly.

I would just straight out copy this structure (just with more bling)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember going through the whole django tutorial a decade ago 😄

Great points @tapadipti and @tibor-mach! I opened this PR to try to start making incremental improvements, but I've now also opened #5153 to suggest a higher-level restructure.

* Rename start -> model management to start -> model registry

* Fix broken link

* Update content/docs/start/model-registry/index.md

---------

Co-authored-by: Dave Berenbaum <dave.berenbaum@gmail.com>
@dberenbaum dberenbaum temporarily deployed to dvc-org-start-add-model-crakny February 22, 2024 16:12 Inactive
@dberenbaum dberenbaum temporarily deployed to dvc-org-start-add-model-crakny February 22, 2024 16:21 Inactive
@tapadipti
Copy link
Contributor

I'd added these 2 redirects, but they seem to be not working when I run this locally:

  "^/doc/start/model-management/model-registry$                                           /doc/start/model-registry/manage-models",
  "^/doc/start/model-management(/.*)?$                                                    /doc/start/model-registry$1",

Not sure what is wrong. @yathomasi any suggestions?

Other than this, LGTM.

@yathomasi
Copy link
Contributor

It seems to be working with preview deployment so we should be fine to merge. BTW, the second rule would cover the first one as well.

https://dvc-org-start-add-model-crakny.herokuapp.com/doc/start/model-management/model-registry -> https://dvc-org-start-add-model-crakny.herokuapp.com/doc/start/model-registry/manage-models

https://dvc-org-start-add-model-crakny.herokuapp.com/doc/start/model-management/test -> https://dvc-org-start-add-model-crakny.herokuapp.com/doc/start/model-registry/test

I would suggest running build mode with yarn build and then run yarn start to test the redirects.

We did have it integrated for development mode with yarn develop, but it might be broken and we are okay with that as redirect logic is little separate from the gatsby project itself.

@tapadipti
Copy link
Contributor

Thanks @yathomasi

BTW, the second rule would cover the first one as well.

Probably not, coz in the first one, the sub-page is also different: model-management/model-registry redirects to model-registry/manage-models

@dberenbaum dberenbaum mentioned this pull request Feb 23, 2024
9 tasks
dberenbaum and others added 2 commits February 23, 2024 16:53
Co-authored-by: Tibor Mach <56956998+tibor-mach@users.noreply.github.com>
Co-authored-by: Tibor Mach <56956998+tibor-mach@users.noreply.github.com>
@dberenbaum dberenbaum temporarily deployed to dvc-org-start-add-model-crakny February 23, 2024 21:53 Inactive
Co-authored-by: Restyled.io <commits@restyled.io>
@dberenbaum dberenbaum temporarily deployed to dvc-org-start-add-model-crakny February 26, 2024 15:53 Inactive
@dberenbaum dberenbaum merged commit b24e829 into main Feb 26, 2024
5 checks passed
@dberenbaum dberenbaum deleted the start-add-model branch February 26, 2024 17:49
@dberenbaum dberenbaum mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants