Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version CR: add package manage name field #778

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Conversation

shcheklein
Copy link
Member

IMPORTANT NOTES (please read, then delete):

  • Have you followed the guidelines in
    Contributing Documentation?

  • The PR title should start with "Fix #bugnum: " (if applicable), followed by a
    clear one-line present-tense summary of the changes introduced in the PR. For
    example: "Fix #bugnum: Introduce the first version of the collection editor.".

  • Please make sure to mention "Fix #bugnum" (if applicable) somewhere in the
    description of the PR. This enables GitHub to link the PR to the corresponding
    bug.

@shcheklein shcheklein temporarily deployed to dvc-org-pr-778 November 6, 2019 19:02 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggested different wording.

@jorgeorpinel
Copy link
Contributor

Meant to approve 😅

@shcheklein shcheklein temporarily deployed to dvc-org-pr-778 November 6, 2019 20:00 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-pr-778 November 6, 2019 20:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants