-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of links to external dependencies in import command #817
Conversation
@dmpetrov style check is failing - please, read the contributing guide and install the pre-commit hook or editor that adjust the style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks! Agreed on avoiding the link to the advanced external data management stuff.
- Please, fix styles
- Simplify the intro (move to description if needed)
- Fix links?
- Fix typos.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll finish this one.
and fix links per #817 (comment) and #817 (review)
Addressed everything. Feel free to also review @dmpetrov. Thanks |
Thank you @jorgeorpinel! |
@shcheklein I'm not an expert in docs. Are there any blockers left to merge? |
@dmpetrov ha! :) no specific reason, sorry. For some reason I though @jorgeorpinel has merged it already. |
👍 |
External-dependencies is quite advanced concept that is necessary only in rear optimization cases. It is better not to use and reference to external-dependencies if there is no real need.