api: Discourse API "proxy" endpoint at /api/comments #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
reviewed
Nov 25, 2019
shcheklein
reviewed
Nov 25, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
changed the title
jorgeorpinel
changed the title
jorgeorpinel
added
website: eng-doc
jorgeorpinel
reviewed
Dec 1, 2019
jorgeorpinel
suggested changes
Dec 1, 2019
|
Made some changes in error responses |
shcheklein
approved these changes
Dec 2, 2019
jorgeorpinel
suggested changes
Dec 2, 2019
There was a problem hiding this comment.
Thanks Alex! Just one more suggestion in #819 (comment) and it seems you may need to solve conflicts with master branch.
|
I guess we could also add a small section in REAMDE describing this endpoint's spec? Just so in the future we remember why it exists, and what request/response (payloads) are expected. |
|
Added |
shcheklein
approved these changes
Dec 3, 2019
|
@iAdramelk please resolve the conflicts ^^ |
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
This comment described rationale to why we created this api endpoint
iAdramelk
force-pushed
the
forum-proxy
branch
from
40d4fbf
to
6b9d01a
Compare
|
@shcheklein Rebased it. |
|
thanks @iAdramelk ! |
jorgeorpinel
reviewed
Dec 5, 2019
Comment on lines
+1
to
+10
| /* | ||
| * This API endpoint is used by https://blog.dvc.org | ||
| * to get comments count for the post, it gets | ||
| * discuss.dvc.org topic url as a param and returns | ||
| * comments count or error. | ||
| * | ||
| * It made this way to configure CORS, reduce user's payload | ||
| * and to add potential ability to cache comments count | ||
| * in the future. | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API handle to return comments count to use in blog.dvc.org (see iterative/blog#8).