Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for dvc metrics diff #933

Merged
merged 65 commits into from
Feb 13, 2020
Merged

add docs for dvc metrics diff #933

merged 65 commits into from
Feb 13, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jan 19, 2020

Fixes #921 (to reflect iterative/dvc/pull/3051)

@efiop efiop changed the title add docs for dvc metrics diff [WIP] add docs for dvc metrics diff Jan 19, 2020
@efiop efiop changed the title [WIP] add docs for dvc metrics diff add docs for dvc metrics diff Jan 20, 2020
@efiop
Copy link
Contributor Author

efiop commented Jan 22, 2020

Hi @jorgeorpinel ! Please take a look when you'll have time. Thank you! 🙂

@jorgeorpinel
Copy link
Contributor

Very nice Ruslan, thanks! We'll take it from here. May have some questions though, will mention you if so (or post on chat).

@shcheklein shcheklein temporarily deployed to dvc-landing-921-comccrlhmerv28 January 24, 2020 21:18 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-comccrlhmerv28 January 24, 2020 22:56 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding missing sidebar.json

@jorgeorpinel

This comment has been minimized.

@shcheklein

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-comccrlhmerv28 January 27, 2020 05:22 Inactive
and review related concepts throughout docs e.g. "Git reference", "working tree"
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-comccrlhmerv28 January 27, 2020 17:25 Inactive
@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-comccrlhmerv28 January 27, 2020 17:28 Inactive
@efiop
Copy link
Contributor Author

efiop commented Jan 27, 2020

@jorgeorpinel Looks great! Thanks!

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 02:39 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 02:56 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 03:49 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 03:55 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 04:51 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 05:05 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last pending item? And of course:

public/static/docs/command-reference/metrics/diff.md Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-921-52xdqc810dd9mc February 13, 2020 05:22 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🎉(check some last comments, feel free to apply in the regular update if needed), though I think it does not solve #921 - just a first basic iteration + a huge (an important) regular update, good conversation about terminology, fixes, etc. Now we need to iterate on the metrics diff doc itself.

@shcheklein shcheklein merged commit bd0e250 into iterative:master Feb 13, 2020
shcheklein pushed a commit that referenced this pull request Feb 13, 2020
…ext) (#962)

* add docs for dvc metrics diff

* nav: add `metrics diff` to sidebar

* cmd ref: typos in `metrics diff`

* cmd ref: rewrite `metrics diff` ref and
and review related concepts throughout docs e.g. "Git reference", "working tree"

* cmd ref: update descs, review options, link all metrics subcmds
addresses #933 (review)
as well as #933 (review)
and #933 (review)

* cmd ref: update cmd argument descriptions for `diff` and `metics diff`

* metrics diff: big terminology review around the intro of this new command
per #933 (review) et al.

* term: review usage of "hash", "commit hash", "SHA", and "MD5"
per #933 (review)

* term: rewrite definition of "workspace"
per #933 (review)

* cmd ref: change link from `metrics diff` options to `metrics show`
per #933 (comment)

* cmd ref: update example in `dvc metrics diff` and similar ones
per #933 (review)

* cmd ref: simplify dvc gc -a option
per #933 (review)
and #933 (review)

* cmd ref: use "reference" more than "revision" in diff
per #933 (review)

* cmd ref: link term "revision" in diff and `metrics diff`
also per #933 (review)

* term: put Git ref exapmles before term and link
per #933 (review)

* cmd ref: friendlier explanation of "tip of default branch"
per #933 (review)

* cmd ref: use tag name instead of term "the revision"
per #933 (review)

* term: revert some "revision"->"reference" changes, and related simplifications
per #933 (review)

* cmd ref: review desc. of `-a` options throughout refs

* cmd ref: update diff params
per iterative/dvc/pull/3244

* cmd ref: update notes around moving/static Git refs in import and update
per #933 (review)

* revert workspace glossary entry
per #933 (review)

* tutorial: use full name of Deep Dive Tutorial in title and links
per #933 (review)

* user-guide: undo change on "binary" literal for analytics example
per #933 (review)

* use-cases: avoid term "revision" in data-registries
per #933 (review)

* term: avoid "checksum" in favor of file "hash" value
per #933 (review)

* term: SHA hash -> hash (Git commit context)
per #962 (comment)

Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
@jorgeorpinel
Copy link
Contributor

OK I think #933 (comment) was the only pending thing here actually – now addressed in the latest regular updates PR.

The rest was extracted to #959

shcheklein pushed a commit that referenced this pull request Feb 14, 2020
* cmd ref: copy edits and improve `move` examples, adding one with `import`
related to https://discordapp.com/channels/485586884165107732/485596304961962003/676360262416203776

* tutorials: correct section title in versioning
per #933 (comment)

* term: review "point" (file hash context)
per #552 (comment)
@efiop efiop deleted the 921 branch February 15, 2020 00:30
efiop pushed a commit to iterative/dvc that referenced this pull request Feb 17, 2020
* get/import: update cmd and url arg descs with correct behavior

* get/import: update path arg desc as well (See previous commit)

* get/imp: udpate help output with simpler terms
per #3277 (review)

* api: url->URL in a docstring

* metrics show: update help output per
per iterative/dvc.org#933 (review)

* diff: update `diff` and `metrics diff` help desc to match docs
per iterative/dvc.org#933 (review)

* diff: update autocomplete scripts
per #3308 (comment)

* diff: update help output again
per iterative/dvc.org#933 (review)

* diff/metrics diff: update help output yet again
per iterative/dvc.org#933 (comment)

* term" under X control -> tracked by X
efiop added a commit to iterative/dvc that referenced this pull request Feb 17, 2020
* get/import: update cmd and url arg descs with correct behavior

* get/import: update path arg desc as well (See previous commit)

* get/imp: udpate help output with simpler terms
per #3277 (review)

* api: url->URL in a docstring

* metrics show: update help output per
per iterative/dvc.org#933 (review)

* diff: update `diff` and `metrics diff` help desc to match docs
per iterative/dvc.org#933 (review)

* diff: update autocomplete scripts
per #3308 (comment)

* diff: update help output again
per iterative/dvc.org#933 (review)

* diff/metrics diff: update help output yet again
per iterative/dvc.org#933 (comment)

Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd ref: create doc for metrics diff
3 participants