Autocomplete for file names doesn't work (partially) [bash]

[belskikh]

Hello!
When I use autocompletion script from here https://github.com/iterative/dvc.org/blob/master/static/docs/user-guide/autocomplete.md it doesn't complete file and directory names from current directory for the command dvc repro ....
But if I add some flag, for example dvc repro --force ... then it works fine.
What should be changed in bash autocomplete script to allow autocompletion for dvc repro ... without any flags?

[efiop]

Hi @belskikh !

Thanks for the feedback! I suppose you'd like to contribute a fix for it? @MrOutis should be able to help with it.

For the record: moved issue from dvc.org repo to dvc repo.

[belskikh]

Hi, @efiop
Yes, I will fix it, if someone helps me

[ghost]

@belskikh , are you using the latest version of the script?
It should be working (or at least it does for me), the line that deals with this is the following:

dvc/scripts/completion/dvc.zsh

Line 150 in dd8598e

"*:Stages:_files -g '(*.dvc|Dvcfile)'"

[belskikh]

@MrOutis I am using this version

dvc/scripts/completion/dvc.bash

Line 1 in dd8598e

#!/usr/bin/env bash

[ghost]

check this out, @belskikh :

[belskikh]

@MrOutis that's awesome, and I will definetly try zsh , but for standard Ubuntu bash terminal it doesn't work.
Can you help me to understand, what I should add/change in dvc.bash script to fix it?

[ghost]

ohh my bad, @belskikh ! 🙈

I don't have a good understanding of Bash's completion engine, but you'll need to add something like compgen -f -X '!*.dvc' over here

dvc/scripts/completion/dvc.bash

Lines 57 to 63 in dd8598e

	if [ "${COMP_CWORD}" -eq 1 ]; then
	case "$word" in
	-*) COMPREPLY=($(compgen -W "$_dvc_options" -- "$word")) ;;
	*) COMPREPLY=($(compgen -W "$_dvc_commands" -- "$word")) ;;
	esac
	elif [ "${COMP_CWORD}" -eq 2 ]; then
	local options_list="_dvc_${COMP_WORDS[1]}"

Be aware that some commands accepts something more than just stage files (the ones ending in .dvc).

The script itself have some references that you can look up to understand how the file was created, I'll leave you with one more: https://www.linuxjournal.com/content/more-using-bash-complete-command

By the way, installing Zsh is not that hard:

# Download and install from the package repository 
sudo apt-get install zsh

#[ch]ange [sh]ell to Zsh
chsh -s $(which zsh)

And you are all set!

If you want colors and stuff like that, I can recommend you the pure prompt

I'm currently using spaceship-prompt but requires a little bit more of configuration.

There's also geometry prompt

Those are my favorites 😅 .

Anyways, if you manage to make completion work with bash it would be awesome! good luck 🦆

[casperdcl]

this is annoying. doesn't work for me for dvc add in the latest version either

[ghost]

@casperdcl , Bash, right?

[casperdcl]

@MrOutis if it was zsh I'd assign you :D

[ghost]

@casperdcl, please feel free 🙂

[g-simmons2]

Not having the completions is definitely annoying, I switched to zsh just to have them :)

Would it be possible to make the completions work for 3-token commands (not sure if this is the right terminology) - for example dvc pipeline show <tab to choose a file>?

The current behavior for dvc pipeline show <tab> is to list the available options:

 -- option --
--help     -h  -- Show help message related to the command.                                                                                             
--quiet    -q  -- Be quiet.                                                                                                                             
--verbose  -v  -- Be verbose. 

And the output for dvc pipeline show incomplete_filename<tab> is

-- no more arguments --

meaning one has to type the complete filename by hand.

Would certainly be a nice to have!

[casperdcl]

@g-simmons2 definitely possible but you're talking about #1924 (zsh).

I'll submit a bash PR soon...

[g-simmons2]

@casperdcl If it works on bash I'll switch back 😄

[verasativa]

+1 on the annoyed crew here, I'm looking forward for @casperdcl PR 🙄

[casperdcl]

looking forward for @casperdcl PR

hah me too :D

[casperdcl]

Fix coming soon (#3360)!

[efiop]

@casperdcl Should we create a ticket for subdir support?

[casperdcl]

definitely will do it soon :)