Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing progress #3332

Closed
casperdcl opened this issue Feb 14, 2020 · 1 comment · Fixed by #3335
Closed

missing progress #3332

casperdcl opened this issue Feb 14, 2020 · 1 comment · Fixed by #3335
Assignees
@casperdcl
Labels
discussion requires active participation to reach a conclusion enhancement Enhances DVC question I have a question? refactoring Factoring and re-factoring research ui user interface / interaction

Comments

@casperdcl
Copy link
Contributor

any reason why no_progress_bar=True in these three places?

  • remote.gdrive.RemoteGDrive.gdrive_upload_file()
  • remote.base.RemoteBASE._get_dir_info_checksum():self.cache.upload()
  • remote.gs.RemoteGDrive.RemoteGS._upload() and _download()

(related: #3060)
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Feb 14, 2020
@casperdcl casperdcl added discussion requires active participation to reach a conclusion enhancement Enhances DVC question I have a question? research ui user interface / interaction labels Feb 14, 2020
@triage-new-issues triage-new-issues bot removed triage Needs to be triaged labels Feb 14, 2020
@casperdcl casperdcl mentioned this issue Feb 14, 2020
Merged
4 tasks
@maxhora
Copy link
Contributor

maxhora commented Feb 14, 2020

@casperdcl both places in gdrive and gs remotes expect no_progress_bar value to be passed from RemoteBase class. Default True values seems are only the preference to be silent by default if internal methods will be reused in future by gdrive or gs.

@casperdcl casperdcl self-assigned this Feb 14, 2020
@casperdcl casperdcl added the refactoring Factoring and re-factoring label Feb 14, 2020
casperdcl added a commit to casperdcl/dvc that referenced this issue Feb 14, 2020
@casperdcl
ui: show missing progress
56886ff 
Fixes iterative#3332
@casperdcl casperdcl mentioned this issue Feb 14, 2020
Merged
3 tasks
casperdcl added a commit to casperdcl/dvc that referenced this issue Feb 14, 2020
@casperdcl
ui: show missing progress
0724e7e 
Fixes iterative#3332
@weekly-digest weekly-digest bot mentioned this issue Feb 16, 2020
Closed
efiop pushed a commit that referenced this issue Feb 19, 2020
@casperdcl
ui: fix missing progress & tidy (#3335)
37de65f 
* ui: show missing progress

Fixes #3332

* ui: more verbose progress

* remote: base: back to no_progres_bar=True
@weekly-digest weekly-digest bot mentioned this issue Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
discussion requires active participation to reach a conclusion enhancement Enhances DVC question I have a question? refactoring Factoring and re-factoring research ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: fix missing progress & tidy casperdcl/dvc
2 participants
@maxhora @casperdcl