-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff: support targets #3388
Comments
It is a good feature idea but probably not a critical one. @DavidGOrtega I'd appreciate it if you provide more context to understand how critical the issue is? |
@dmpetrov I tried it according to the docs and I found that issue. For ci is not an issue aside of having more features. |
@jorgeorpinel as far as I remember it was removed for two reasons: it was not a priority and it seems fine not to have it because Is there a good use case when we need targets (except backward compatibility)? It is important to understand the priority. |
Ohhh I see. I think this issue is mainly about a discrepancy between
UPDATE: Should we close this issue? The docs are up to date now, actually. |
Looks like it does.
returns: diff --git a/dvc/api.py b/dvc/api.py
index def9e8cf..d1312baa 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -18,10 +18,10 @@ class UrlNotDvcRepoError(DvcException):
def get_url(path, repo=None, rev=None, remote=None):
- """
- Returns the full URL to the data artifact specified by its `path` in a
- `repo`.
- NOTE: There is no guarantee that the file actually exists in that location.
+ """Returns URL to the storage location of a data artifact tracked
+ by DVC, specified by its path in a repo.
+
+ NOTE: There's no guarantee that the file actually exists in that location. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Let's keep it. This is a pretty relevant feature. Especially considering that there was some confusion around |
OK
You don't even need |
I've started a draft pull request on this if anyone would like to give early feedback the changes: #4938 |
Please provide information about your setup
Ubuntu 18.04
Dvc 0.84.0
The text was updated successfully, but these errors were encountered: